feat(events): promote session/end and prompt/submit canonical route families (#258 v2 s1) - #351
Merged
Merged
Conversation
Vendor the Codex 0.147.0 wire schemas, including the absence of a SessionEnd output schema, and retain scrubbed Claude/Codex binary captures for lifecycle replay.
Keep sessionEnd and promptSubmit out of canonicalHookEvents so config handler hooks remain unchanged; only normalized filesystem event routes use the new internal identities. Project exactly the blocking, context, and observe-only channels pinned for each host.
Exercise discovery, native envelope validation, projection, adapter planning, capability state, and lifecycle replay for session/end and prompt/submit, and document the route-only public contract.
Codex and plugin adapter revisions collided with #350's bumps on rebase; re-adjudicate to 1.4.0/1.19.0 and bump portable to 1.4.0 for its two new honest eventRoute rows. The four-render fixture replay test gets an explicit 30s timeout following the integration-config precedent.
🦋 Changeset detectedLatest commit: 12c7903 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First staged slice of the #258 v2 event-route promotion: canonical
session/endandprompt/submitfamilies compiled into native host hooks with the full G10 evidence bar (pinned per-host contract, decode fixtures, fail-closed projection, honest capability rows).Support matrix
session/endprompt/submitSessionEnd, observe-onlyUserPromptSubmit, deny + additionalContextSessionEnd, observe-only (no output schema at rust-v0.147.0)UserPromptSubmit, deny + additionalContextsessionEnd, observe-only; cloud honestlyunavailable(no editor-lifetime session boundary)beforeSubmitPrompt, deny only (continue:false+user_message; no context channel)Evidence pins
continue+ optionaluser_message, matcher evaluates against literalUserPromptSubmit) and fire-and-forget sessionEnd; cloud-agent unavailability recorded as an availability dimension. Live capture attempt blocked by missing Cursor authentication — recorded as a dated evidence bullet; the official contract is the pinned source.Design decisions
sessionEnd/promptSubmitlive in a separateeventRouteOnlyHookEventsvocabulary and are not added to config-facingcanonicalHookEvents, so no newconfig.hooks.*handler keys exist.projectEventDocumentfails closed: session/end rejects deny/replacement/context everywhere; prompt/submit rejects prompt replacement everywhere and context on Cursor.validateNativeEventEnvelopepins per-host required fields (Codex requiresturn_id/model/permission_modeand reason constother; Cursor requiresprompt+ typed attachments).Gates (local, after rebase onto 15a7854)
Part of #258.