fix: second-wave review findings (framework group) - #354
Conversation
🦋 Changeset detectedLatest commit: 4f9e6c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f9e6c6dc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| const isInternalRelativePath = (value: string): boolean => | ||
| value === './' || | ||
| (value.startsWith('./') && isInternalSubdirectory(value.slice(2))); |
There was a problem hiding this comment.
Allow harmless dot segments in relative marketplace paths
When an authored plugin.source or metadata.pluginRoot contains a no-op segment such as ./plugins/./review-tools, this helper now rejects it because isInternalSubdirectory forbids both . and ... Such paths remain inside the marketplace and were accepted by the previous validation, so this introduces a compatibility regression unrelated to the backslash-traversal fix; reject only .. segments or normalize the path before checking it.
Useful? React with 👍 / 👎.
Summary
Test plan