Skip to content

fix: second-wave review findings (framework group) - #354

Merged
ScriptedAlchemy merged 7 commits into
mainfrom
fix/findings-wave2-framework
Sep 3, 2026
Merged

fix: second-wave review findings (framework group)#354
ScriptedAlchemy merged 7 commits into
mainfrom
fix/findings-wave2-framework

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

Test plan

  • scoped suites (watcher, claude validation, host adapters, adapter metadata, replay service)
  • route-unit pool, typecheck, lint

@changeset-bot

changeset-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4f9e6c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agent-bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T02:44:28.388926Z 4f9e6c6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy merged commit bb0754f into main Sep 3, 2026
7 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f9e6c6dc7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


const isInternalRelativePath = (value: string): boolean =>
value === './' ||
(value.startsWith('./') && isInternalSubdirectory(value.slice(2)));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Allow harmless dot segments in relative marketplace paths

When an authored plugin.source or metadata.pluginRoot contains a no-op segment such as ./plugins/./review-tools, this helper now rejects it because isInternalSubdirectory forbids both . and ... Such paths remain inside the marketplace and were accepted by the previous validation, so this introduces a compatibility regression unrelated to the backslash-traversal fix; reject only .. segments or normalize the path before checking it.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed on main in #364 (merge 305161a).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant