Skip to content

feat(events): promote tool/failure and compact route families (#258 v2 s2) - #357

Merged
ScriptedAlchemy merged 3 commits into
mainfrom
feat/258-events-s2
Sep 3, 2026
Merged

feat(events): promote tool/failure and compact route families (#258 v2 s2)#357
ScriptedAlchemy merged 3 commits into
mainfrom
feat/258-events-s2

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • Promotes three Compile semantic event route v2 families into native host hooks #258 v2 families with the v1 evidence bar: tool/failure (Claude PostToolUseFailure + Cursor postToolUseFailure; Codex honestly unavailable), compact/before (Claude/Codex PreCompact + Cursor preCompact), compact/after (Claude/Codex PostCompact; Cursor unavailable)
  • Per-host projection semantics with fail-closed notes (Cursor compact is observational and cannot block; no context/output channel on Cursor tool failure)
  • Dated capability evidence incl. an honest note that live cursor-agent capture could not authenticate, so the pinned official contract is the evidence source
  • Fixtures per host + lifecycle replay coverage + adapter metadata/capability pins; changeset included

Test plan

  • scoped suites 96/97 (one failure is the workspace/open starter path assertion, reproduced identically on clean main in a worktree — pre-existing/environmental, green in CI)
  • route-unit pool, typecheck, lint

Keep the three families route-only and project only host channels whose pinned semantics are proven, rejecting unsupported result effects instead of inferring control.
Vendor the Codex 0.147.0 compact schemas byte-for-byte and retain scrubbed Claude captures, including the sensitive post-compaction summary fixture.
Exercise discovery, capability asymmetry, native validation, fail-closed projection, adapter planning, and lifecycle replay while documenting the route-only contract.
@ScriptedAlchemy
ScriptedAlchemy merged commit 2119cee into main Sep 3, 2026
@changeset-bot

changeset-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1fa818b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agent-bundle Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T02:54:46.052507Z 1fa818b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1fa818b094

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +28 to +29
"compact/after": { "nativeEvent": "PostCompact", "state": "supported" },
"compact/before": { "nativeEvent": "PreCompact", "state": "supported" },

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Advance revisions for adapters gaining compact routes

These mappings change the Codex adapter's generated hook artifacts, but codex.ts still reports the parent's adapterRevision: '1.5.0'; likewise, the composite plugin adapter now emits compact/before hooks while retaining 1.20.0. Because artifact freshness in matchesTargetMetadata relies on these revisions, artifacts produced before and after this behavior change are indistinguishable by adapter provenance. Increment both adapter revisions and update their metadata expectations.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed on main in #364 (merge 305161a).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant