Skip to content

fix(notices): #361 review findings (expiry, ack eligibility, README) - #363

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/findings-wave3-runtime
Sep 3, 2026
Merged

fix(notices): #361 review findings (expiry, ack eligibility, README)#363
ScriptedAlchemy merged 1 commit into
mainfrom
fix/findings-wave3-runtime

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • Retriable attempted notices past expiresAt now expire in both the admission expiry scan and transitionExpiry (fully-attempted notices keep their terminal attempt record) — r3920980938
  • acknowledge() applies the same createdAt <= invocation.startedAt eligibility boundary as inbox/event admission, so receipts cannot predate creation — r3920980943
  • README Notices section rewritten to match the shipped API (acknowledge, states, receipts, retries, selector) — r3920980948

Test plan

  • notices suites 29/29 incl. two new red-without-fix regressions
  • typecheck + lint

@changeset-bot

changeset-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e2eaed5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@agent-bundle/runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T04:25:57.076868Z e2eaed5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy merged commit 6a2b341 into main Sep 3, 2026
4 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the fix/findings-wave3-runtime branch September 3, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant