-
Notifications
You must be signed in to change notification settings - Fork 0
feat(inspect): explain selected and omitted host components per target (#100) #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| "agent-bundle": minor | ||
| --- | ||
|
|
||
| Explain host component selection in `inspect`. Every inspection plan now | ||
| lists `selected` components beside `skipped`, and each component that needs a | ||
| host capability carries that target's own four-state judgment as | ||
| `capability` — `supported` with pinned evidence for emitted surfaces, or | ||
| `degraded`/`unavailable`/`prohibited` with the host's reason for omissions — | ||
| so `inspect --json` explains why a surface is absent from a bundle in the | ||
| host's words. An adapter that publishes no row for a needed capability reads | ||
| as an honest `unavailable`. Human `inspect` output prints one accounting line | ||
| per target followed by each omission and its reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an advanced
TargetRegistryuses a JavaScript or third-party adapter whose otherwise-validCapabilityStatehas enumerable extension fields,isCapabilityStateaccepts it but this spread copies those fields into the public inspection. For example, an extension field namednameoverrides the canonical capability name set above, while a circular extension value makesinspect --jsonfail duringstableJsonserialization. Construct the discriminated capability output from its contract fields and assign the canonical name last rather than spreading the adapter-owned object.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed — addressed in follow-up #409 (2d1cd86).
componentCapabilityFornow builds the output from the four-state contract fields only (capabilityContract/capabilityEvidenceContract) and assigns the canonicalnamelast.api.test.tscovers adapter rows decorated withname: 'shadow'and a cyclic extension field: inspection reports exactly the contract fields with the canonical name andJSON.stringifysucceeds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed on main by #409 (62138ef, the #100 follow-up lane):
componentCapabilityForprojects only the four-state contract fields (capabilityContract, exhaustive overstate) and assigns the canonicalnamelast;api.test.tscovers a decorated row with anamecollision and a cyclic value. #408 carried an equivalent projection and dropped it in favour of #409 during rebase.