-
Notifications
You must be signed in to change notification settings - Fork 0
feat(codex): author marketplace policy and record distribution/install policy parity (#188 S3) #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d7e0550
feat(codex): author marketplace policy and record distribution/instal…
ScriptedAlchemy a809d0d
fix(codex): refuse NOT_AVAILABLE for the self-installing marketplace …
ScriptedAlchemy 7e818b9
fix(codex): reject line terminators in contained paths and range-chec…
ScriptedAlchemy 438b8ee
fix(codex): range-check numeric IPv4 authorities and validate npm ver…
ScriptedAlchemy 82c0c41
fix(codex): accept bracketed IPv6 authorities and semver whitespace i…
ScriptedAlchemy c395a7e
fix(codex): apply git check-ref-format to marketplace refs and reject…
ScriptedAlchemy e629711
fix(codex): accept RFC 3986 userinfo (user:password, percent-escapes)…
ScriptedAlchemy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'agent-bundle': minor | ||
| --- | ||
|
|
||
| Author the Codex marketplace entry (`codex.marketplace` displayName, category, and documented `policy.installation` / `policy.authentication` values, with the category following the plugin interface category; `installation: NOT_AVAILABLE` fails the build with `codex.marketplace.policy.installation.not-installable` because live `codex plugin add` refuses it and the emitted `INSTALL.md` / `installBundle()` run that command), admit every documented marketplace source form (local string or object, Git root `url`, `git-subdir`, `npm`) in the pinned marketplace schema with structurally validated Git and registry URLs, and publish dated four-state Codex distribution rows for marketplace discovery, sources, cache layout, enable state, `codex plugin` / `codex plugin marketplace` JSON contracts, feature flags, managed `requirements.toml`, `allow_managed_hooks_only`, `restrict_to_allowed_sources`, and workspace publishing, backed by live codex-cli 0.147.0 probes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
149 changes: 149 additions & 0 deletions
149
packages/agent-bundle/src/adapters/capabilities/codex-0.147.0.json
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an author selects the newly accepted
NOT_AVAILABLEpolicy, the marketplace correctly marks this plugin as unavailable for installation, but both the generated instructions (src/install/surface.ts:44-45) andinstallPublicCli(src/install/install.ts:222-230) still unconditionally runcodex plugin add. Thus a valid configuration produces a bundle whose advertised and programmatic installation path is rejected by the host; either reject this policy for self-installing bundles or make those installation surfaces policy-aware.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with a live probe: codex-cli 0.147.0 accepts
codex plugin marketplace addfor aNOT_AVAILABLEentry and then refusescodex plugin add demo@demo-marketwithplugin demo is not available for install in marketplace demo-market— the exact commandINSTALL.mdandinstallBundle()run. Fixed in a809d0d: the adapter now rejects an authoredinstallation: NOT_AVAILABLEwithcodex.marketplace.policy.installation.not-installable(schema still documents the enum value; the capability row records the probe and the rejection), so the self-installing artifact can no longer advertise an install path the host refuses.AVAILABLEandINSTALLED_BY_DEFAULTremain admitted, with tests for both sides.