Skip to content

fix(release): rewrite preview peer ranges via --peerDeps so npm installs matched pkg.pr.new pairs cleanly #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 2 commits into from
Aug 30, 2026
Merged

fix(release): rewrite preview peer ranges via --peerDeps so npm installs matched pkg.pr.new pairs cleanly #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66f29fc
fix(release): pass --peerDeps to preview:publish so matched preview p…
ScriptedAlchemy Aug 30, 2026
3db7cf3
docs(preview): drop the --legacy-peer-deps caveat now that matched pr…
ScriptedAlchemy Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions docs/preview-packages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,22 @@ npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/rsc-runtime@

pnpm and yarn accept the same URLs (`pnpm add <url>`, `yarn add agent-bundle@<url>`).

Previews carry the version string `0.0.0-preview-<sha>`, which does not satisfy
the `agent-bundle@^0.1.0` peer range declared by `@agent-bundle/rsc-runtime`.
When installing both previews into the same project with npm, add
`--legacy-peer-deps`; pnpm reports the mismatch as a warning and proceeds.
Previews carry the version string `0.0.0-preview-<sha>`, and the publish
rewrites the `agent-bundle` peer range inside the `@agent-bundle/rsc-runtime`
preview tarball to that exact preview version (`--peerDeps`). Installing both
packages from the same sha therefore works with stock npm — no
`--legacy-peer-deps` needed. Mixing two different shas fails with `ERESOLVE`
by design; use one sha (or one PR number) for both URLs. Previews published
before the peer rewrite landed (PR #46) still carry the original
`agent-bundle@^0.1.0` range, so pair-installing those older shas with npm
still requires `--legacy-peer-deps`.

## Where previews come from

`.github/workflows/package-preview.yml` runs
`pnpm preview:publish` (`pkg-pr-new publish --previewVersion --no-compact
--no-template './packages/agent-bundle' './packages/rsc-runtime'`) after a
full build, on every pull request and on every push to `main`. Runs for
`pnpm preview:publish` (`pkg-pr-new publish --previewVersion --peerDeps
--no-compact --no-template './packages/agent-bundle' './packages/rsc-runtime'`)
after a full build, on every pull request and on every push to `main`. Runs for
`main` pushes use a per-commit concurrency group, so overlapping pushes
cannot cancel one another and every `main` commit has an installable
snapshot. (PR runs cancel superseded builds for the same PR — only the
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"changeset": "changeset",
"version-packages": "changeset version",
"release": "pnpm build && changeset publish",
"preview:publish": "pkg-pr-new publish --previewVersion --no-compact --no-template './packages/agent-bundle' './packages/rsc-runtime'",
"preview:publish": "pkg-pr-new publish --previewVersion --peerDeps --no-compact --no-template './packages/agent-bundle' './packages/rsc-runtime'",
"pack:dry-run": "pnpm build && npm pack ./packages/agent-bundle --dry-run --json",
"audit:release": "pnpm lint:package && attw --pack --profile esm-only packages/agent-bundle && node scripts/audit-packed-release.mjs",
"check:release": "pnpm pack:dry-run && pnpm audit:release && pnpm test:packed",
Expand Down
Loading