Skip to content

test(build): pass the project root to the composed configs in the plugin-registry test - #523

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/plugin-registry-test-cwd
Sep 4, 2026
Merged

test(build): pass the project root to the composed configs in the plugin-registry test#523
ScriptedAlchemy merged 1 commit into
mainfrom
fix/plugin-registry-test-cwd

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Summary

main stopped typechecking at 8f90c5394: #518 made cwd (the project root) a required option of composeEntryLibConfig and composeMcpAppsRsbuildConfig, and #509's framework-plugin-registration.test.ts — merged between #518's last rebase and its merge — calls both without it. Each PR was green on its own head; the combination is not. This passes cwd: '/project' in the three calls, the same value compose-layers.test.ts uses. Test-only; no runtime change, hence skip-changeset.

Review status

Per the maintainer's instruction this PR carries no comments; review threads are answered here.

@ScriptedAlchemy
test: pass the project root to the composed configs in the plugin-reg…
4c013cb 
…istry test

#518 made cwd required on composeEntryLibConfig and
composeMcpAppsRsbuildConfig; #509's framework-plugin-registration test
landed beside it without the argument, so main no longer typechecks.
@ScriptedAlchemy ScriptedAlchemy added the skip-changeset PR changes a publishable package but ships no observable change; changeset not required label Sep 4, 2026
@changeset-bot

changeset-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4c013cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-04T04:55:34.950814Z 4c013cb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy ScriptedAlchemy mentioned this pull request Sep 4, 2026
Merged
@pkg-pr-new

pkg-pr-new Bot commented Sep 4, 2026

Copy link
Copy Markdown 
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@523

npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@523

npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@523

commit: 4c013cb

@ScriptedAlchemy
ScriptedAlchemy merged commit 5a86149 into main Sep 4, 2026
13 of 14 checks passed
This was referenced Sep 4, 2026
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip-changeset PR changes a publishable package but ships no observable change; changeset not required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ScriptedAlchemy