ci: run required checks on merge_group for the merge queue - #536
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
…ue readiness audit (#557) The Verify matrix comment in ci.yml still named "Verify (Node 24)" as the required check on main; #549 replaced it with the static "Verify gate" job. Audit of every required-check workflow for merge_group readiness (#536) found no other gap; findings and the settings commands live in the PR body.
Summary
Adds a
merge_group:(branches: main) trigger to every workflow that provides a required check onmain—ci.yml(Verify, Examples check, Release gates, Host install proofs),docs.yml(Docs site), andchangeset.yml(Changeset present) — so a GitHub merge queue can gate on them.Context: twice today individually-green PRs broke
mainwhen combined (#486×#490, #518×#509). GitHub's merge queue is the fix, but it is only offered to organization-owned repositories: creating amerge_queueruleset on this user-owned repo returns422 Invalid rule 'merge_queue'. As the fallback, classic branch protection onmainnow requires the six checks above and an up-to-date branch (required_status_checks.strict: true). Themerge_grouptriggers are therefore dormant, documented as such in each workflow, and make queue adoption a single ruleset away once the repository moves to an organization.Details
ci.yml:merge_grouptrigger; Verify runs the Node 24 leg for queue entries (the required context isVerify (Node 24)), the full matrix still runs on every main push. Thechangesjob stays PR-only, so queue entries never skip heavy jobs (same as main pushes). Concurrency is SHA-keyed with no cancellation for queue entries.docs.yml:merge_grouptrigger; build only, deploy steps remain gated on push/dispatch ofmain.changeset.yml:merge_grouptrigger; the queue run reports success without evaluating (a merge_group event carries no PR labels and stacks earlier queue entries). Enforcement remains on the pull request, which must be green to enter the queue. Concurrency group falls back togithub.shawhen there is no PR number.Validated with
actionlint. CI-only:skip-changeset.