You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Comments-only follow-up to #614, from the owner's deslop rule (every PR runs a deslop lane over its diff before review; #614 had already merged when the rule arrived, so its edits land here). No behaviour, selector, colour, ARIA attribute or workflow step changes — website/theme/index.tsx and website/styles/index.css comments only. skip-changeset: website is private.
Deslop: cursor-grok-4.6-high-fast, 8 edits — JSDoc that restated the function it sat on (contentId, socialLinkName), prop restatements and a "class names kept for CSS" aside in the SwitchAppearance JSDoc, "assistive technology reads the live DOM" after a setAttribute, #590 citations and cross-file references in CSS block comments (the file's existing comments cite neither), and a failing-ratio list already repeated next to each token. Kept: every why — why the switch stays a div, why aria-pressed waits for mount, the contrast ratios beside each value.
Self-review
Reviewer: claude-fable-5-1-thinking-high (deslop lane: cursor-grok-4.6-high-fast). Verified mechanically that the comment-stripped CSS and TSX are byte-identical to main; typecheck and lint pass. Two low findings, both fixed (7193dfa): the removed "class names are kept so the theme's CSS still applies" sentence was the only statement of the contract with @rspress/core's CSS and the index.css focus selector — restored as a half-sentence; the removed "assistive technology reads the live DOM" justified setting aria-label in an effect rather than in the SSG HTML — restored as a clause. Reflow stub line fixed.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skip-changesetPR changes a publishable package but ships no observable change; changeset not required
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments-only follow-up to #614, from the owner's deslop rule (every PR runs a deslop lane over its diff before review; #614 had already merged when the rule arrived, so its edits land here). No behaviour, selector, colour, ARIA attribute or workflow step changes —
website/theme/index.tsxandwebsite/styles/index.csscomments only.skip-changeset:websiteis private.Deslop:
cursor-grok-4.6-high-fast, 8 edits — JSDoc that restated the function it sat on (contentId,socialLinkName), prop restatements and a "class names kept for CSS" aside in theSwitchAppearanceJSDoc, "assistive technology reads the live DOM" after asetAttribute,#590citations and cross-file references in CSS block comments (the file's existing comments cite neither), and a failing-ratio list already repeated next to each token. Kept: every why — why the switch stays adiv, whyaria-pressedwaits for mount, the contrast ratios beside each value.Self-review
Reviewer:
claude-fable-5-1-thinking-high(deslop lane:cursor-grok-4.6-high-fast). Verified mechanically that the comment-stripped CSS and TSX are byte-identical tomain; typecheck and lint pass. Two low findings, both fixed (7193dfa): the removed "class names are kept so the theme's CSS still applies" sentence was the only statement of the contract with@rspress/core's CSS and theindex.cssfocus selector — restored as a half-sentence; the removed "assistive technology reads the live DOM" justified settingaria-labelin an effect rather than in the SSG HTML — restored as a clause. Reflow stub line fixed.Refs #614, #590.