Skip to content

docs(website): trim comments that restated the a11y/contrast code (#614 deslop) - #622

Merged
ScriptedAlchemy merged 2 commits into
mainfrom
docs/590-p3-deslop
Sep 5, 2026
Merged

docs(website): trim comments that restated the a11y/contrast code (#614 deslop)#622
ScriptedAlchemy merged 2 commits into
mainfrom
docs/590-p3-deslop

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Comments-only follow-up to #614, from the owner's deslop rule (every PR runs a deslop lane over its diff before review; #614 had already merged when the rule arrived, so its edits land here). No behaviour, selector, colour, ARIA attribute or workflow step changes — website/theme/index.tsx and website/styles/index.css comments only. skip-changeset: website is private.

Deslop: cursor-grok-4.6-high-fast, 8 edits — JSDoc that restated the function it sat on (contentId, socialLinkName), prop restatements and a "class names kept for CSS" aside in the SwitchAppearance JSDoc, "assistive technology reads the live DOM" after a setAttribute, #590 citations and cross-file references in CSS block comments (the file's existing comments cite neither), and a failing-ratio list already repeated next to each token. Kept: every why — why the switch stays a div, why aria-pressed waits for mount, the contrast ratios beside each value.

Self-review

Reviewer: claude-fable-5-1-thinking-high (deslop lane: cursor-grok-4.6-high-fast). Verified mechanically that the comment-stripped CSS and TSX are byte-identical to main; typecheck and lint pass. Two low findings, both fixed (7193dfa): the removed "class names are kept so the theme's CSS still applies" sentence was the only statement of the contract with @rspress/core's CSS and the index.css focus selector — restored as a half-sentence; the removed "assistive technology reads the live DOM" justified setting aria-label in an effect rather than in the SSG HTML — restored as a clause. Reflow stub line fixed.

Refs #614, #590.

@ScriptedAlchemy ScriptedAlchemy added the skip-changeset PR changes a publishable package but ships no observable change; changeset not required label Sep 5, 2026
@changeset-bot

changeset-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7193dfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 5, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@622
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@622
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/rsc-markdown-stream@622
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@622

commit: 7193dfa

@ScriptedAlchemy
ScriptedAlchemy marked this pull request as ready for review September 5, 2026 09:27
@ScriptedAlchemy
ScriptedAlchemy enabled auto-merge (squash) September 5, 2026 09:27
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T09:29:12.545963Z 7193dfa Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changeset PR changes a publishable package but ships no observable change; changeset not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant