Skip to content

docs(website): fit home artifact tree column - #626

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
docs/617-home-overflow
Sep 5, 2026
Merged

docs(website): fit home artifact tree column#626
ScriptedAlchemy merged 1 commit into
mainfrom
docs/617-home-overflow

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove trailing artifact-tree comments that overflow the 484 px home-page comparison column, in both English and Chinese
  • export CapabilityRow and HostCapabilityTable from agent-bundle and reuse their owning source definitions in the generated-reference plugin
  • add one patch changeset for the public type exports

Closes #617

Verification

  • pnpm docs:site:build
  • pnpm build && pnpm typecheck && pnpm lint && pnpm test:unit
  • Playwright, built site, 1440×900:
    • before: artifact fence scrollWidth 679, clientWidth 484
    • after (en): scrollWidth 484, clientWidth 484
    • after (zh): scrollWidth 484, clientWidth 484

Item 2

Done. The deferred types describe the pinned capability-table contract and now have one owner in src/adapters/capability-state.ts; the package root publicly exports them, and the website plugin imports them instead of maintaining copies. The website imports the owning source module because its typecheck runs before package dist exists, matching the docs build's existing source-compilation model.

Deslop

Deslop: GPT-5.6 Sol, 0 edits. The complete diff against origin/main had no restating comments, defensive branches, casts, or unrelated helpers to remove.

Self-review

Reviewer: Claude Fable 5.1 Thinking High (change-risk-reviewer), pass 1.

No blocking or medium findings. Dispositions for low-severity notes:

  • Changeset (#626): confirmed by this PR number; retain.
  • Website typecheck includes package source transitively: accepted, consistent with the existing TypeDoc/source build and required because docs build before dist.
  • HostCapabilityTable has no in-package runtime consumer: accepted intentionally; it is a public description of the pinned table consumed by repository tooling.
  • CapabilityRow.payload overlaps the narrower event-route row: no change; the public row models heterogeneous capability JSON while the event-route type enforces its runtime subset.
  • Removed comments carried details: no change; surrounding prose already explains per-host wrappers, shared entries, installation instructions, manifests, and host hook indexing, while the issue explicitly selected dropping trailing comments.

Reviewer: Claude Fable 5.1 Thinking High (change-risk-reviewer), pass 2.

No blocking findings; merge-ready. Dispositions for remaining non-blocking notes:

  • Bare CapabilityRow.payload TypeDoc: no change; the public type intentionally models heterogeneous capability JSON, while EventRouteCapabilityTableEntry documents the narrower canonical payload mapping.
  • Three removed fence annotations: no change; the home prose and linked distribution documentation own those details, and docs(website): home page artifact tree overflows its ab-compare column after #578 #617 explicitly permits dropping trailing comments to retain the comparison layout.
  • No persistent 484 px regression assertion: no change in this small content fix; the required built-site Playwright acceptance was run in both locales, and broader authored-fence overflow coverage remains separate test-infrastructure scope.

@changeset-bot

changeset-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: cf0d606

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agent-bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 5, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@626
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@626
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/rsc-markdown-stream@626
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@626

commit: cf0d606

@ScriptedAlchemy
ScriptedAlchemy enabled auto-merge (squash) September 5, 2026 10:22
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T10:22:37.833031Z cf0d606 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(website): home page artifact tree overflows its ab-compare column after #578

1 participant