test: guard packed release artifacts - #645
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 170683d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
ScriptedAlchemy
marked this pull request as ready for review
September 5, 2026 20:16
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/agent-bundle/distbefore and aftertest:packedand fail if packed fixtures mutate the publishable treeVerification
pnpm buildpnpm typecheckpnpm lintpnpm test:unitpnpm test:packed(rerun after review fixes)dist/mcp-server-runtime.js;node scripts/check-dist-fresh.mjsrejected it, then passed after restorationOwner review
Addresses the release-artifact ownership follow-up on #636 and #566. The final #636 merge already isolated the synthetic build/tarball; this PR makes that invariant executable at both packed-test and release boundaries.
Deslop
Deslop: GPT-5.6 Sol, 2 edits (removed unnecessary exception plumbing in the packed runner; aligned the freshness test name with all rejected states).
Self-review
Reviewer: Claude Fable 5.1 Thinking High (
change-risk-reviewer).First pass:
Second pass after fixes: no blocking findings; both prior findings resolved. Residual concurrent-file-removal diagnostics and ambient fixture-environment messaging are safe-direction edge cases and do not affect release ownership; no change. The script-level digest guard is exercised in the passing direction by
test:packed, while digest sensitivity has a focused unit test.