fix: make state purge receipt-owned - #647
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 622a7ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
commit: |
ScriptedAlchemy
force-pushed
the
fix/state-root-ownership
branch
from
September 5, 2026 20:22
5df94a6 to
d6391d3
Compare
# Conflicts: # packages/agent-bundle/src/install/doctor.ts # packages/agent-bundle/src/install/receipt.ts # packages/agent-bundle/src/install/state-root.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install.mjsmainCloses #644
Related: #592
Follow-up to #642
Validation
pnpm buildpnpm typecheckpnpm lintpnpm test:unit— 4,235 passed, 6 skipped (4,241 total)pnpm docs:site:build— locale parity, diagnostic coverage, site build, and link checks passedDeslop
Deslop: GPT-5.6 Sol, 0 edits after the final full-diff pass.
Self-review
Reviewer: Claude Fable 5.1 Thinking High.
Initial passes found no merge blockers. Fixed every actionable finding: marker-only roots uninstall cleanly; keep-data plan/apply receipt output matches; non-writable declared roots record
unprovenwithout failing install; partial marker acquisition rolls back; byte-identical remnant reinstalls refresh receipts; reader/writer server-name handling matches; generated uninstall honors oldstateRootreceipts; Doctor checks every effective root for legacy overlap; and EN/ZH installation guides state receipt-proven deletion.After merging current
main, conflicts instate-root.ts,receipt.ts, anddoctor.tswere resolved by preserving main authoritative artifact-manifest lookup and layering multi-server ownership on it. Fixture tests now write authoritative manifests. Full gates and 162 focused tests passed on the merged base. The final review found no Critical findings and marked the branch safe for auto-merge. Its marker-literal hygiene warning was fixed by centralizingstateOwnershipMarkerFileincore/types.ts; the same reviewer confirmed exact HEAD622a7ca13ahas no cycle, generated-source change, or behavior regression.Dispositions for remaining non-blocking notes:
state/duplicate reporting, and public remnant Doctor wording: cosmetic, no deletion difference; deferred.rmdirfails closed; no recursive deletion or data loss.