Fix development host install lifecycle - #677
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c1cdb87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uninstall --forcerepair a broken Codex registrationCloses #676
Validation
pnpm build— passedpnpm typecheck— passedpnpm lint— passedpnpm test:unit— passed (27 files, 554 tests)pnpm test:host-install— passed (4 files, 25 tests, including real Claude and Codex host adoption)pnpm exec rstest packages/agent-bundle/tests/install.test.ts packages/agent-bundle/tests/uninstall.test.ts packages/agent-bundle/tests/doctor.test.ts packages/agent-bundle/tests/dev-workbench.test.ts— passed (4 files, 144 tests)pnpm docs:site:build— passedDeslop
Deslop: GPT-5.6 Sol, 3 edits.
Kept ephemeral preparation under the OS temp directory, reused one marketplace-list parser across install/Doctor, and bounded Codex config fallback to local marketplace sources.
Self-review
Reviewer: Claude Fable 5.1 Thinking High
First pass findings and disposition:
CODEX_HOME/config.toml; the regression now models the real nonzero exits.pathshape lacked isolated unit coverage. Existing real Claude host-adoption teardown/restart covers the shape and passed.Second pass: no blocking findings. Its remaining local-source-type concern was fixed by requiring
source_type = "local"; the real-host clean lifecycle suite and matching nonzero Codex-runner repair regression passed.