Skip to content

Fix development host install lifecycle - #677

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/codex-dev-install-676
Sep 6, 2026
Merged

Fix development host install lifecycle#677
ScriptedAlchemy merged 1 commit into
mainfrom
fix/codex-dev-install-676

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • register Claude and Codex development installs from stable per-project, receipt-owned sources
  • replace crash leftovers on restart and unregister development installs on server teardown
  • report dangling receipt-owned marketplace sources as AB7333 and let uninstall --force repair a broken Codex registration
  • cover clean teardown, restart, stale-source replacement, and post-teardown host health for Claude and Codex

Closes #676

Validation

  • pnpm build — passed
  • pnpm typecheck — passed
  • pnpm lint — passed
  • pnpm test:unit — passed (27 files, 554 tests)
  • pnpm test:host-install — passed (4 files, 25 tests, including real Claude and Codex host adoption)
  • pnpm exec rstest packages/agent-bundle/tests/install.test.ts packages/agent-bundle/tests/uninstall.test.ts packages/agent-bundle/tests/doctor.test.ts packages/agent-bundle/tests/dev-workbench.test.ts — passed (4 files, 144 tests)
  • pnpm docs:site:build — passed

Deslop

Deslop: GPT-5.6 Sol, 3 edits.

Kept ephemeral preparation under the OS temp directory, reused one marketplace-list parser across install/Doctor, and bounded Codex config fallback to local marketplace sources.

Self-review

Reviewer: Claude Fable 5.1 Thinking High

First pass findings and disposition:

  • High: current Codex makes both plugin and marketplace JSON listings fail for a dangling source. Fixed by reading the receipt-owned local marketplace source from CODEX_HOME/config.toml; the regression now models the real nonzero exits.
  • Medium: a crash-left stable source was not refreshed. Fixed with staged replacement and rollback on the first sync of each session, plus a stale-source restart regression.
  • Medium: Workbench lifecycle docs were stale. Updated matching English and Chinese pages.
  • Low: project-local preparation directories could leak after abnormal exit. Removed by retaining OS-temp preparation.
  • Low: Claude path shape lacked isolated unit coverage. Existing real Claude host-adoption teardown/restart covers the shape and passed.

Second pass: no blocking findings. Its remaining local-source-type concern was fixed by requiring source_type = "local"; the real-host clean lifecycle suite and matching nonzero Codex-runner repair regression passed.

@changeset-bot

changeset-bot Bot commented Sep 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c1cdb87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agent-bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dev --install-host codex leaves a dangling marketplace registration that breaks codex plugin list for every plugin

1 participant