feat(portable): record eleven more clients of the emitted artifact - #723
Conversation
🦋 Changeset detectedLatest commit: 9f38233 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b095d7782
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "required": [], | ||
| "shadowedBy": [], | ||
| "evidence": [ | ||
| "2026-09-06: `npm view @earendil-works/pi version` returned \"npm error 404\", and `pi-coding-agent@0.0.1` is a \"Placeholder package name reservation for pi-coding-agent\" with no `bin` field, so no Pi executable is installable from npm under either name and nothing about Pi's handling of this artifact can be exercised.", |
There was a problem hiding this comment.
Probe Pi's actual published package before assigning
none
This probes two unrelated package names and therefore incorrectly concludes that Pi has no installable release. Pi's upstream coding-agent README installs the CLI with npm install -g @mariozechner/pi-coding-agent; because that release was never exercised, the none tier causes the generated host reference and INSTALL.md to falsely report that Pi loads nothing. Probe the official scoped package and record its actual skill compatibility instead.
AGENTS.md reference: AGENTS.md:L128-L131
Useful? React with 👍 / 👎.
|
The deferred record-only findings in this PR now have a concrete owner: #728, checked against main It covers Copilot CLI manifest precedence/MCP evidence scope, CodeWhale remote-policy qualifications, VS Code registration wording, Hermes repository-source classification, and per-client rendered-output regressions. Cline's actual copy action remains Do not repeat work already fixed by #727: duplicate authored client keys, the stale Pi The completed records remain records of the existing portable artifact, not evidence that new native adapters or authenticated tool journeys were delivered. No code or merge action was performed during this reconciliation. |
Records ten more third-party clients of the artifact Agent Bundle already
emits, in the same pinned
clientsblock and through the same validator that#721 landed. No adapter, no projection, and no compiler output changes: every
row is dated evidence about a reader of the existing package.
agent-pluginsagent-pluginsagent-pluginsagent-pluginsagent-pluginsskillsskillsskillsskillsskillsEach record carries the paths the client reads, its install action under the
role its own documentation gives it, and a dated row per surface it does and
does not load.
INSTALL.mdand the generated en/zh host reference render themthrough
clientCompatibilityFrom, so a record that claims a tier its rows donot support, loads a surface without naming the file it reads, or declares an
install block without a source and exactly one install action fails the build.
Gate
Run on
portable-client-records-b, which contains currentorigin/main(
72a8857ebe):pnpm build— passpnpm typecheck— passpnpm lint— passpnpm test:unit— 0 failed, 4433 passedpnpm docs:site:build— pass (locale parity and link checks clean)packages/agent-bundle/tests/{install-surface,portable-adapter}.test.ts— 47 passedSelf-review (
gpt-5.6-sol-max, tip9f38233d97)Fixed:
noneagainst an existing release.@mariozechner/pi-coding-agent@0.73.1installs and exposes a
pibinary whose own--helpdocuments--skill <path>; its packageddocs/skills.mdanddocs/packages.mdpin thediscovery contract, including
skills/as a package convention directory. Therecord is now
skillswith aregisteraction and a live-probe evidence set;the missing turn (no provider key) is recorded as the one thing not exercised.
adapter, and the pinned contract now lives on that issue. A
none-tierportable row would contradict it.
placeholdersrow printed for a bundle with no MCP document.placeholdersis a behavior ofmcp.json, so it now maps to that path inCLIENT_SURFACE_PATHSand is gated like every other surface.registerrole for a clientthat reads the emitted tree where it lies (Pi's
--skill, and the same shapein the follow-up records);
INSTALL.mdrenders "Register:" for it, and thevalidator requires exactly one
installorregisteraction.Deferred to a follow-up on this table, each with the reviewer's reason recorded:
Copilot's
.plugin/plugin.jsonprecedence row and its stdio-only MCP evidence,CodeWhale's
network_hostsrestriction in its narrowed MCP reason, theinstall-versus-registerre-reading of the VS Codechat.pluginLocationsrowand the Cline copy row, a
repositoryinstall source for Hermes, and per-clienttier/path/install assertions in
portable-adapter.test.ts. None of them changeswhat the compiler writes; all of them change record prose or one rendered word.
Gate (re-run at
9f38233d97)pnpm build,pnpm typecheck,pnpm lint— passpnpm test:unit— 0 failed, 4433 passedpnpm docs:site:build— passpackages/agent-bundle/tests/{install-surface,portable-adapter}.test.ts— 47 passed