Skip to content

fix(test): replay pending App terminal events - #743

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/736-review-followup
Sep 7, 2026
Merged

fix(test): replay pending App terminal events#743
ScriptedAlchemy merged 1 commit into
mainfrom
fix/736-review-followup

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Follow-up to #741. Addresses post-merge review threads deferred terminal replay and display-context consistency.

Summary

  • Retain whichever opening terminal notification the bridge accepted — result, represented error, or cancellation — and replay it after input when an App initializes again.
  • Restore the harness's previous replacement semantics for caller-supplied host.context; canonical toolInfo is still injected, while inline/desktop defaults apply only when no context was supplied.
  • Add reinitialize and asymmetric display-context regression checks, bilingual testing docs, and one patch changeset.

Local merge gate

Branch contains origin/main at 4447ec8734.

pnpm build && pnpm typecheck && pnpm lint && pnpm test:unit
# passed: build, typecheck, lint (1,493 files), 4,482 tests / 0 failed (4,476 passed, 6 skipped)

pnpm --filter @agent-bundle-example/mcp-app check
pnpm --dir examples/mcp-app test:browser-app
# passed: validate/build/typecheck; 14 / 14 browser-App tests

pnpm docs:site:build
# passed: locale parity, 0 broken links / 29,989 anchors

Red/green checks separately proved both review failures before implementation: the deferred reinitialize lacked its terminal frame, and a caller displayMode: 'fullscreen' incorrectly inherited availableDisplayModes: ['inline'] and platform: 'desktop'.

Deslop

Deslop: GPT-5.6 Sol, 0 edits.

Self-review

Reviewer: Claude Fable 5.1 Thinking (high), change-risk-reviewer, two passes.

  • Verified response → input → retained terminal ordering, exactly-once publication, default/deferred behavior, and transport-failure handling.
  • Verified caller-context replacement plus canonical toolInfo, test falsifiability, bilingual parity, and changeset.
  • Two low wording/metadata findings fixed between passes; final pass found no merge blocker.

@changeset-bot

changeset-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1ad6556

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
agent-bundle Patch
create-agent-bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T09:50:37.466759Z 1ad6556 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy merged commit e3e78e2 into main Sep 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant