Skip to content

fix(test): isolate Amp installs from ambient XDG config #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptedAlchemy merged 1 commit into from
Sep 7, 2026
Merged

fix(test): isolate Amp installs from ambient XDG config #744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/agent-bundle/tests/amp-install.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { readInstallReceipt } from '../src/install/receipt.ts';
import { uninstallBundle } from '../src/install/uninstall.ts';
import { writeInstallFixtureManifest } from './support/install-fixture.ts';

const isolatedEnvironment: Readonly<NodeJS.ProcessEnv> = {};
const pluginName = 'amp-install-fixture';

const writeBundle = async (
Expand Down Expand Up @@ -48,6 +49,7 @@ it('installs, replaces, and uninstalls only the receipt-owned Amp directory', as
try {
const installed = await installBundle({
commandRunner: forbiddenRunner(),
environment: isolatedEnvironment,
from: bundle,
home,
host: 'amp',
Expand Down Expand Up @@ -80,6 +82,7 @@ it('installs, replaces, and uninstalls only the receipt-owned Amp directory', as

const unchanged = await installBundle({
commandRunner: forbiddenRunner(),
environment: isolatedEnvironment,
from: bundle,
home,
host: 'amp',
Expand All @@ -91,6 +94,7 @@ it('installs, replaces, and uninstalls only the receipt-owned Amp directory', as
await writeBundle(bundle, '1.0.0', 'second');
const replaced = await installBundle({
commandRunner: forbiddenRunner(),
environment: isolatedEnvironment,
from: bundle,
home,
host: 'amp',
Expand All @@ -104,6 +108,7 @@ it('installs, replaces, and uninstalls only the receipt-owned Amp directory', as

const planned = await uninstallBundle({
commandRunner: forbiddenRunner(),
environment: isolatedEnvironment,
from: bundle,
home,
host: 'amp',
Expand All @@ -116,6 +121,7 @@ it('installs, replaces, and uninstalls only the receipt-owned Amp directory', as

const uninstalled = await uninstallBundle({
commandRunner: forbiddenRunner(),
environment: isolatedEnvironment,
from: bundle,
home,
host: 'amp',
Expand Down Expand Up @@ -194,6 +200,7 @@ it('installs a mixed-case portable plugin name accepted by the Amp planner', asy
try {
const installed = await installBundle({
commandRunner: forbiddenRunner(),
environment: isolatedEnvironment,
from: bundle,
home,
host: 'amp',
Expand Down Expand Up @@ -221,6 +228,7 @@ it('rejects an Amp manifest name that could escape the plugin root', async () =>
try {
await expect(installBundle({
commandRunner: forbiddenRunner(),
environment: isolatedEnvironment,
from: bundle,
home,
host: 'amp',
Expand All @@ -244,6 +252,7 @@ it('refuses to replace a foreign Amp directory even with --replace', async () =>

try {
await expect(installBundle({
environment: isolatedEnvironment,
from: bundle,
home,
host: 'amp',
Expand All @@ -270,6 +279,7 @@ it('refuses a symlinked Amp plugin ancestor before writing outside the host root

try {
await expect(installBundle({
environment: isolatedEnvironment,
from: bundle,
home,
host: 'amp',
Expand All @@ -292,6 +302,7 @@ it('refuses modified or unlisted files inside the generated Amp directory', asyn

try {
await expect(installBundle({
environment: isolatedEnvironment,
from: bundle,
home,
host: 'amp',
Expand Down
Loading