fix(dev): harden runtime relay against Rsbuild internals - #76
Conversation
Ignore private HMR status frames and make undocumented compiler timing assumptions fail loudly so Rsbuild upgrades cannot silently reload or wedge runtime sessions.
🦋 Changeset detectedLatest commit: d91308b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1f573dc5d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Allow legitimate overlapping compile hooks while rejecting ambiguous identities, and keep startup reconciliation plus encoded HMR paths intact.
Summary
full-reloadkind; privateok/hashand unknown frames are inertURLSearchParams, and proxy the encoded normalizeddev.client.pathinstead of duplicating/rsbuild-hmrRefs #72.
Conformance dispositions
full-reload-only frame contract; deeper provider-owned channel tracked in Replace raw Rsbuild HMR frames with a provider-owned Runtime App reload channel #73compilingsession state without treatingproviderTailas an initial-compile barrier; startup reconciliation now preserves the bootstrap generationTest plan
pnpm buildpnpm typecheckpnpm --filter @agent-bundle/rsc-agent-runtime-demo typecheckpnpm lintpnpm test:unit(1,775 tests; 0 failed)EADDRINUSE, and the focused test passed on the one permitted rerunruntime-playground-capture.test.tswith integration config + prebuilt flags (including compile-error recovery)runtime-playground.e2e.test.tswith integration config + prebuilt flagsruntime-playground-hmr.e2e.test.tswith integration config + prebuilt flags