perf(test): drop rstest maxWorkers pins, isolate per RSTEST_WORKER_ID - #90
perf(test): drop rstest maxWorkers pins, isolate per RSTEST_WORKER_ID#90ScriptedAlchemy wants to merge 1 commit into
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 801fe49aec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
commit: |
801fe49 to
7578a38
Compare
|
Superseded by #118, which merges this branch's per-RSTEST_WORKER_ID isolation intact (commit 7578a38 carried over unchanged) and adds the root-cause fixes for the flakes the serial pin was hiding, plus the burn-in-backed integration worker derivation. Credit for the isolation design and the unit/packed/watch pool unpinning stands — #118 is the single coherent landing of both efforts. |
Merge conflict resolution (origin/main @ 8bf9618 merged in 458af9c)The three conflicted files ( Verified in a fresh worktree at the merge: typecheck, lint, Codex P1: browser pool setup (fixed in 7e6cb02)Confirmed empirically — BLOCKER: unpinned integration pool races on the shared example dist
Mechanism: |
Why
Worker pins are gone.
Rstest sizes the pool from CPU. Shared roots are isolated per RSTEST_WORKER_ID.
Unit isolate is off. Integration isolate stays on because logs-real.e2e fails when sharing a worker.
Local proof: unit 1775 passed in ~75s. Integration 556 passed in ~200s. Packed 22 passed, 1 skipped, ~56s.
No changeset. examples/rsc-agent-runtime untouched.