[AMDGPU] m107, m120, m127, m139, m154 are invalid.#2
Open
carlobertolli wants to merge 1 commit into
Open
Conversation
Preserving NaN sign is not required by nay standards. The compiler uses this property to fold FNEG into operand modifier for VOP3. Disabling such folding prevents formation of FMAs, amongst other optimizations, and has a performance impact. For discussion, see llvm/llvm-project#201440
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserving NaN sign is not required by nay standards. The compiler uses this property to fold FNEG into operand modifier for VOP3. Disabling such folding prevents formation of FMAs, amongst other optimizations, and has a performance impact. For discussion, see
llvm/llvm-project#201440
Note
Low Risk
README-only catalog updates; no build, runtime, or compiler behavior changes.
Overview
Updates the AMDGPU bugs found table in
amdgpu/README.mdonly—no LLVM or fuzzer code changes.Reclassified as invalid (not compiler bugs): m107, m120, m127, m139, and m154 now show ✅ on all three toolchain columns (ROCm 7.2.3, LLVM HEAD, ROCm HEAD), meaning the differential reproducer no longer treats them as
-O0/-O2mismatches. Descriptions add that NaN sign differences from foldingfneginto VOP3 operand modifiers are acceptable (no standard mandates NaN sign) and that blocking those folds would hurt performance (e.g. FMA formation); rationale points to llvm/llvm-project#201440. m120, m127, m139, and m154 cross-reference m107 with “INVALID: see m107.”Other table tweaks: m138 (
v_bitop3revert missing return) goes from ✅/❌/❌ back to ❌/❌/❌ on all columns. m140’s first status cell becomes❌❌(likely a typo vs a single ❌).Reviewed by Cursor Bugbot for commit 5b76823. Bugbot is set up for automated code reviews on this repo. Configure here.