Preserve authorization expiry in payment extension configs#8143
Open
jenny-codes wants to merge 1 commit into
Open
Preserve authorization expiry in payment extension configs#8143jenny-codes wants to merge 1 commit into
jenny-codes wants to merge 1 commit into
Conversation
Core accepts the optional enforce_authorization_expiry configuration and Connected PayPal declares it, but Shopify CLI does not recognize the field. Zod therefore strips it before deployment and the published extension keeps the backward-compatible one-year buffer. Complete the extension-config design introduced in shop/world#453909 by supporting the field for credit card, custom credit card, custom onsite, and offsite extensions in both transform directions. Add schema and round-trip regression coverage so a configured value cannot silently disappear again. The field remains optional to preserve existing partner behavior. Tracking: shop/issues-card-payment-methods#1366 Co-authored-by: AI (Pi/GPT-5.6 Sol) <noreply@pi.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Shopify CLI's payment extension schemas don't recognize the optional
enforce_authorization_expiryfield. When the field is present inshopify.extension.toml, schema parsing strips it before the deploy configuration is generated.This prevents payment extensions from preserving their configured authorization-expiry behavior during deployment. The field remains optional, so existing extensions keep their current behavior when it is omitted.
WHAT is this pull request doing?
Implementation
AuthorizationExpirySchemaforenforce_authorization_expiry.shopify.extension.toml-> deploy configurationThis PR only updates CLI schema validation and configuration transformation. It does not change authorization-expiry defaults, enable the option for existing extensions, or add it to redeemable or card-present extensions.
How to test your changes?
Result: 67 tests passed. Repository lint and type checks also passed.
Checklist