Make payments extension support flags optional#8147
Open
Shuhala wants to merge 1 commit into
Open
Conversation
Shuhala
force-pushed
the
optional-payments-support-flags
branch
from
July 22, 2026 15:07
145e63e to
12c4b02
Compare
Shuhala
marked this pull request as ready for review
July 22, 2026 15:08
Shuhala
force-pushed
the
optional-payments-support-flags
branch
from
July 22, 2026 20:52
12c4b02 to
ed601ba
Compare
Makes supports_installments, supports_deferred_payments, and supports_3ds optional (default false) in payments app extension config so partners can omit them. supports_3ds stays required for credit_card and custom_credit_card extensions. Companion to the core change in Shopify/world (shop/world#940396). Assisted-By: devx/662f85f5-a0c5-4b77-b4e3-a07404abaf08
Shuhala
force-pushed
the
optional-payments-support-flags
branch
from
July 22, 2026 22:55
ed601ba to
e878dcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes
supports_installments,supports_deferred_payments, andsupports_3dsoptional (defaultfalse) in payments app extension TOML config schemas, so partners can omit them.supports_3dsstays required forcredit_cardandcustom_credit_cardextensions.Why
Companion to the core change in shop/world#940396 that relaxed the same properties on the server side. Without this CLI-side change,
shopify app deployrejects configs that omit these fields even though core now accepts them.How
DeferredPaymentsSchema:supports_installmentsandsupports_deferred_payments→.default(false)OffsitePaymentsAppExtensionSchemaandCustomOnsitePaymentsAppExtensionSchema: overridesupports_3dsto.default(false)in their.extend()blocksCreditCardPaymentsAppExtensionSchemaandCustomCreditCardPaymentsAppExtensionSchema: unchanged —supports_3dsremains required viaConfirmationSchemafalseUsing
.default(false)rather than.optional()keeps the parsed Zod types asboolean, so the TOML-to-deploy transform functions continue to send booleans.