[Refactor] Use Object.fromEntries in flattenDevExtensionTranslations - #8536
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Replace the hand-rolled convertMapToExtensionTranslationMap helper with the built-in Object.fromEntries. The helper had a single call site and reimplemented standard library behaviour. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Suleimanlatrsh
approved these changes
Sep 15, 2026
Suleimanlatrsh
left a comment
Suleimanlatrsh
left a comment
There was a problem hiding this comment.
Tested locally and checked the translation fallbacks. Looks good 👍
gonzaloriestra
marked this pull request as ready for review
September 16, 2026 08:56
github-actions
Bot
added
the
no-changelog
gonzaloriestra
approved these changes
Sep 16, 2026
gonzaloriestra
enabled auto-merge
September 16, 2026 08:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
convertMapToExtensionTranslationMapwas a hand-rolled helper that copied aMapinto a plain object — exactly what the built-inObject.fromEntriesdoes. It had a single call site, so the indirection added a function to read without adding any behaviour.WHAT is this pull request doing?
Replace
convertMapToExtensionTranslationMapwithObject.fromEntriesinflattenDevExtensionTranslationsand delete the now-unused helper frompackages/ui-extensions-server-kit/src/i18n.ts.The function's public signature and
ExtensionTranslationMapreturn type are unchanged, andObject.fromEntriesaccepts aMapdirectly, so the merged-translations behaviour is identical.How to manually test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add