Conversation
The changelog entry is included in the 4.8 patch release. Assisted-By: devx/b2d440f7-e236-42a9-a6ae-e4e7085b2daa
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Correct the fixture checksum in the filesystem test and add the missing patch changeset.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds DESIGN.md support to theme pull, push, and package workflows.
Changes:
- Discovers and partitions
DESIGN.md. - Includes it in upload, deletion, and generated packages.
- Adds fixtures and test coverage.
File summaries
| File | Summary |
|---|---|
packages/theme/src/cli/utilities/theme-uploader.ts |
Handles documentation ordering during synchronization. |
packages/theme/src/cli/utilities/theme-uploader.test.ts |
Tests DESIGN.md upload and deletion behavior. |
packages/theme/src/cli/utilities/theme-fs.ts |
Discovers and categorizes DESIGN.md. |
packages/theme/src/cli/utilities/theme-fs.test.ts |
Tests discovery and partitioning; expected checksum requires correction. |
packages/theme/src/cli/utilities/fixtures/theme/DESIGN.md |
Adds a DESIGN.md fixture. |
packages/theme/src/cli/services/package.ts |
Includes DESIGN.md in generated packages. |
packages/theme/src/cli/services/package.test.ts |
Verifies packaged DESIGN.md inclusion. |
Review details
Suppressed comments (1)
packages/theme/src/cli/services/package.ts:10
- This adds user-facing theme packaging behavior, but there is no new
.changesetfile in the PR even though the checklist says one was added. Add a patch changeset for the theme package before merging.
'DESIGN.md',
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // Check that all expected files are present with correct checksums | ||
| const expectedFiles = [ | ||
| {checksum: '6e3520cc5a5c4cdb1267f36406c732a1', key: 'AGENTS.md'}, | ||
| {checksum: 'f5e9ce97aef578fc4e2e369a3c271234', key: 'DESIGN.md'}, |
EvilGenius13
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Shopify CLI does not handle DESIGN.md returned by the checksums API.
WHAT is this pull request doing?
Include DESIGN.md in theme pull, push, and package.
How to manually test your changes?
Notice that
DESIGN.mdis pulled, pushed, and included in the generated package.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add