[Tests] Cover theme dev error page rendering and HTML escaping - #8551
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Suleimanlatrsh
approved these changes
Sep 15, 2026
Suleimanlatrsh
left a comment
There was a problem hiding this comment.
Tested locally, including HTML in the error messages and code. Looks good 👍
gonzaloriestra
marked this pull request as ready for review
September 16, 2026 08:56
gonzaloriestra
approved these changes
Sep 16, 2026
gonzaloriestra
enabled auto-merge
September 16, 2026 08:57
EvilGenius13
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
getErrorPagerenders the HTML page shown whentheme devfails to render a page, and it had no test coverage. ItsescapeHtmlhelper is the only thing preventing untrusted error text (Liquid error messages, stack traces, file paths from the theme) from being injected as markup into that page, and nothing guarded that behavior against regression.WHAT is this pull request doing?
Adds
error-page.test.tsnext toerror-page.ts, covering the public contract ofgetErrorPage:<script>tag in an error cannot inject markup.Removing the
escapeHtmlcalls fromerror-page.tsmakes the escaping test fail, so the test earns its keep. No production code is changed.How to manually test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add