Conversation
jek
force-pushed
the
app-doctor/findings-merge
branch
from
September 18, 2026 19:58
1463dad to
25d5c2d
Compare
jek
changed the base branch from
main
to
joshlarson/rename-app-doctor-to-app-security
September 21, 2026 13:28
jek
force-pushed
the
app-doctor/findings-merge
branch
from
September 21, 2026 13:30
25d5c2d to
4034747
Compare
jek
changed the title
jek
added this pull request to stack #8610
September 21, 2026 13:32
jek
marked this pull request as ready for review
September 21, 2026 13:51
Base automatically changed from
joshlarson/rename-app-doctor-to-app-security
to
main
September 21, 2026 15:58
Refuse to start a new scan when agent findings or compiled review results already exist, preventing the deterministic check from replacing that work. Add --clean for explicitly discarding the current review and starting over, and update the generated agent instructions to describe the guarded flow. Co-authored-by: AI <noreply@pi.dev> Assisted-By: devx/a43d5d42-941f-47ca-ba7d-47133d5a8cc6
jek
force-pushed
the
app-doctor/findings-merge
branch
from
September 21, 2026 15:58
4034747 to
069ab34
Compare
dmerand
reviewed
Sep 21, 2026
dmerand
left a comment
dmerand
left a comment
Contributor
There was a problem hiding this comment.
This works for me + LGTM overall. I have a few agentic findings worth looking at/resolving before we ship.
- Require explicit --clean; ignore inherited environment values - Reject clean compilation before writing artifacts - Add command-boundary tests for compiled-trace and findings protection Co-authored-by: AI <noreply@pi.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #23971
If agentic findings exist, don't silently remove or invalidate them when running
app security check. Addsapp security check --cleanto start a fresh trace.WHAT is this pull request doing?
app security check --cleanto start a fresh trace & clean up findings filesHow to manually test your changes?
A valid findings.json is needed to fully tophat this
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addAssisted-By: devx/a43d5d42-941f-47ca-ba7d-47133d5a8cc6