Skip to content

ZJIT: skip empty inline frame pass when no inlining occurred - #1050

Open
Nish916 wants to merge 1 commit into
Shopify:masterfrom
Nish916:fix/eliminate-empty-inline-frames-guard
Open

Nish916 wants to merge 1 commit into
Shopify:masterfrom
Nish916:fix/eliminate-empty-inline-frames-guard

Conversation

@Nish916

@Nish916 Nish916 commented Sep 15, 2026

Copy link
Copy Markdown

Summary

Avoid running Function::eliminate_empty_inline_frames in optimizer iterations where inline_methods did not inline anything.

optimize() already records the result of inline_methods in did_inline, so this change uses that existing signal to skip a pass that cannot have new inline-frame pairs to clean up in that iteration.

This keeps the pass unchanged for iterations that actually performed inlining and avoids the unnecessary scan otherwise.

Fixes #1035.

Validation

  • git diff --check
  • Local Rust tests were not run because cargo is not installed in the available local environment; repository CI should provide authoritative build/test validation.

@github-actions github-actions Bot added the jit label Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ZJIT: Don't run Function::eliminate_empty_inline_frames if we didn't inline anything

1 participant