Switch sub-driver and main-driver to support SLGA migration#2842
Open
HunsupJung wants to merge 3 commits into
Open
Switch sub-driver and main-driver to support SLGA migration#2842HunsupJung wants to merge 3 commits into
HunsupJung wants to merge 3 commits into
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 73 files 512 suites 0s ⏱️ For more details on these failures, see this check. Results for commit 21d4cf5. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 21d4cf5 |
HunsupJung
force-pushed
the
feature/slga-migration
branch
3 times, most recently
from
eb1ad32 to
9bff284
Compare
HunsupJung
requested review from
ctowns,
hcarter-775,
nickolas-deboom and
tpmanley
and removed request for
ctowns,
hcarter-775,
nickolas-deboom and
tpmanley
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
HunsupJung
force-pushed
the
feature/slga-migration
branch
from
95dcb25 to
21d4cf5
Compare
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
HunsupJung
force-pushed
the
feature/slga-migration
branch
from
d6d06b2 to
d0d0d76
Compare
tpmanley
reviewed
May 27, 2026
|
|
||
| local function lock_op_event_handler(driver, device, ib, response) | ||
| local tamper_detected = device:get_latest_state( | ||
| device:endpoint_to_component(ib.endopint_id), |
Contributor
There was a problem hiding this comment.
Suggested change
| device:endpoint_to_component(ib.endopint_id), | |
| device:endpoint_to_component(ib.endpoint_id), |
| command_result_info, {state_change = true, visibility = {displayed = false}} | ||
| )) | ||
| device:set_field(lock_utils.BUSY_STATE, false, {persist = true}) | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
Yes, I will fix it.
| MODULAR_PROFILE_UPDATED = "__MODULAR_PROFILE_UPDATED", | ||
| ALIRO_READER_CONFIG_UPDATED = "aliroReaderConfigUpdated", | ||
| LATEST_DOOR_LOCK_FEATURE_MAP = "latestDoorLockFeatureMap", | ||
| LOCK_CODES_COPY_REQUIRED = "lockCodesCopyRequried", |
Contributor
There was a problem hiding this comment.
Suggested change
| LOCK_CODES_COPY_REQUIRED = "lockCodesCopyRequried", | |
| LOCK_CODES_COPY_REQUIRED = "lockCodesCopyRequired", |
| @@ -0,0 +1,758 @@ | |||
| -- Copyright 2025 SmartThings, Inc. | |||
Contributor
There was a problem hiding this comment.
The unit test coverage of this file is currently only 24% so can you add more tests to get more coverage?
Collaborator
Author
There was a problem hiding this comment.
okay, I will improve the coverage.
| end | ||
| end | ||
|
|
||
| ------------------------------------------------------------- |
Contributor
There was a problem hiding this comment.
The headers of these two functions are swapped
| end | ||
| local protocol_versions = {} | ||
| for i, element in ipairs(ib.data.elements) do | ||
| local version = string.format("%s.%s", element.value:byte(1), element.value:byte(2)) |
Contributor
There was a problem hiding this comment.
To avoid shadowing the module-level version:
Suggested change
| local version = string.format("%s.%s", element.value:byte(1), element.value:byte(2)) | |
| local ver = string.format("%s.%s", element.value:byte(1), element.value:byte(2)) |
Comment on lines
+640
to
+641
| local version = string.format("%s.%s", element.value:byte(1), element.value:byte(2)) | ||
| table.insert(protocol_versions, version); |
Contributor
There was a problem hiding this comment.
To avoid shadowing the module-level version:
Suggested change
| local version = string.format("%s.%s", element.value:byte(1), element.value:byte(2)) | |
| table.insert(protocol_versions, version); | |
| local ver = string.format("%s.%s", element.value:byte(1), element.value:byte(2)) | |
| table.insert(protocol_versions, ver); |
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
Summary of Completed Tests
https://smartthings.atlassian.net/wiki/spaces/STHK/pages/5328012565/SLGA+migration+-+Test+Result