-
Notifications
You must be signed in to change notification settings - Fork 0
docs: finalize chore_reconciler_terminal_closed_no_poll (move to implemented_features, update state.md) #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
...nal_closed_no_poll/implementation_plan.md → ...nal_closed_no_poll/implementation_plan.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...features/2026_05_23_chore_reconciler_terminal_closed_no_poll/pipeline_status.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Pipeline Status — chore_reconciler_terminal_closed_no_poll | ||
|
|
||
| ## Idea | ||
| - Status: Complete | ||
| - File: idea.md | ||
|
|
||
| ## Spec | ||
| - Status: Approved | ||
| - Date: 2026-05-23 | ||
| - File: feature_spec.md | ||
| - Cross-model review: GPT-5.5 passed (5 cycles, 8 findings all Accepted) | ||
| - Phases: 1 (single phase, Tier A only; Tier B remains deferred per idea.md) | ||
|
|
||
| ## Plan | ||
| - Status: Approved | ||
| - Date: 2026-05-23 | ||
| - File: implementation_plan.md | ||
| - Cross-model review: GPT-5.5 passed (3 cycles; 2 Accept-Low + 1 Reject-with-counter-evidence) | ||
| - Stories: 3 across 1 epic | ||
| - Phases covered: 1 (Tier A only) | ||
|
|
||
| ## Implementation | ||
| - Status: Complete | ||
| - Date: 2026-05-23 | ||
| - PR: #216 (squash-merged as `95d4c414` to `main`) | ||
| - CI: green (7 checks; lint + typecheck + unit + integration + contract + Docker build + frontend) | ||
| - Stories completed: 3/3 (1.1 migration, 1.2 candidate query + helper, 1.3 worker branch + tests + docs) | ||
| - Gemini review: clean pass (no findings) | ||
| - Final GPT-5.5 review: 1 finding (Low, Rejected with cited counter-evidence — runbook path) | ||
| - New tests: 16 (9 repo + 7 worker integration) | ||
| - Migration: 0017 round-trip verified | ||
| - Tangential idea captured: `chore_migration_test_head_brittleness` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 0 additions & 23 deletions
23
...ct/planned_features/chore_reconciler_terminal_closed_no_poll/pipeline_status.md
This file was deleted.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request title and description indicate that
state.mdhas been updated (including the Alembic head0017_proposals_last_polled_atand a new entry for this change), but this file is missing from the current pull request changes. Please ensurestate.mdis included to maintain an accurate record of the repository state.