TakeDamageInfoBaseWrapper::get_weapon raises exception

[KirillMysnik]

CS:S, Windows

The following code

from entities import TakeDamageInfo
from entities.hooks import EntityCondition
from entities.hooks import EntityPreHook
from memory import make_object


@EntityPreHook(EntityCondition.is_player, 'on_take_damage')
def on_take_damage(args):
    info = make_object(TakeDamageInfo, args[1])
    info.weapon

produces the following exception

[SP] Caught an Exception: 
Traceback (most recent call last): 
  File '..\addons\source-python\plugins\infoweapontest\infoweapontest.py', line 10, in on_take_damage 
    info.weapon 

ValueError: Conversion from 'BaseHandle' (<_entities.BaseEntityHandle object at 0x251F8EF8>) to 'Index' failed. 

when a player shoots another player

[Ayuto]

That seems to be an engine issue. A few years ago @satoon101 made a small snippet that is able to retrieve the weapon in all cases:
http://forums.eventscripts.com/viewtopic.php?f=125&t=46657&p=408464#p408464

It's probably worth adding that directly to SP, so plugin authors don't have to bother with that issue. Thus, I'm going to mark this as an enhancement.

[KirillMysnik]

Thanks! Went with this

def weapon_index_from_damage_info(info):
    if info.attacker == info.inflictor:
        try:
            player = Player(info.attacker)
        except (OverflowError, ValueError):
            return None

        return index_from_inthandle(player.active_weapon)

    else:
        return info.inflictor