CS:S - OnServerOutput Crash

[Frag1337]

EDIT: Please check #404 (comment)

Hello,

I'm currently having an issue where Source.Python crashes when two player's are inside the same trigger_push entity.

This is the console log:

2021-08-22 06:44:52 - sp    -    EXCEPTION    
[SP] Caught an Exception:
Traceback (most recent call last):
  File "..\addons\source-python\plugins\SurfTricks\libs\misc\hooks.py", line 101, in on_touch_pre
    entity = make_object(Entity, args[1])
  File "..\addons\source-python\packages\source-python\entities\_base.py", line 293, in _obj
    return cls(index_from_pointer(ptr))

ValueError: Conversion from "Pointer" (<_memory.Pointer object at 0x011F5C50>) to "Index" failed.

<=> CRASH <=>

Code:

@EntityPreHook(EntityCondition.is_human_player, "touch")
def on_touch_pre(args):
    player = make_object(Entity, args[0])
    entity = make_object(Entity, args[1])

sp info:

sp info

IMPORTANT: Please copy the full output.
--------------------------------------------------------
Checksum      : 5e3156dad6f48fe59901274827251ec8
Date          : 2021-08-23 00:36:57.404125
OS            : Windows-10-10.0.19041
Game          : css
SP version    : 705
Github commit : 38e4fe48579f9445b878624a9439ce10e28aa7e6
Server plugins:
   00: Metamod:Source 1.12.0-dev+1145
   01: Source.Python, (C) 2012-2020, Source.Python Team.
   02: Tickrate_Enabler 0.4, Didrole
SP plugins:
   00: SurfTricks, 1.6, http://trick.surf
--------------------------------------------------------

[jordanbriere]

It's very unlikely that the exception itself is related to the crash you are encountering and probably just means the touching entity isn't networked. Try using BaseEntity instead or catch the exception and exit the call. That said, my first guess as far as the crash is concerned would be a clash between SP's and SM's hook. Try with only SP installed as well as only a minimal reproducible plugin loaded and see if you are still crashing.

[Frag1337]

Thank you for your reply. You are right, it isn't actually the cause, it was just find through the error log.

So I've tried to debug the exact cause why this crash was happening, since it was reproducable. I've started with disabling Metamod + Sourcemod, it was still crashing, disabled 100 Tick Enabler, it was still crashing, disabled everything related to hooking in my Source.Python plugin, and it was still crashing.. Hmm, I went further ahead and finally found the cause for it, which I would never thought of.

sp info

sp info

IMPORTANT: Please copy the full output.
--------------------------------------------------------
Checksum      : 9ef93fdfb37c25f134642a2fd0231d68
Date          : 2021-08-23 21:45:24.462681
OS            : Windows-10-10.0.19041
Game          : css
SP version    : 705
Github commit : 38e4fe48579f9445b878624a9439ce10e28aa7e6
Server plugins:
   00: Source.Python, (C) 2012-2020, Source.Python Team.
SP plugins:
   00: test
--------------------------------------------------------

test/test.py

from listeners import OnServerOutput
from core import OutputReturn

@OnServerOutput
def on_server_output(severity, message):
    if message.startswith("test123456"):
        return OutputReturn.BLOCK

I have no idea why OnServerOutput is crashing the server, when two players enter a trigger_push, but atleast I found the cause.

I can upload video of proof in some minutes.

Ohne.Titel.mp4

EDIT: While trying to find the crashing function, I've only had this one-time print after the crash, no idea if this might be related to here or anything sort of:

[jordanbriere]

Similar crashes related to the output listener were reported into #400. But since you provided more context I guess we can continue the discussion here until we know more. For now, two questions come to mind;

• Do you crash if you don't call startswith?
• Do you crash if you don't block the output?

[Frag1337]

I will try to give you answers on your questions tomorrow, thanks for your fast reply.

[Frag1337]

from listeners import OnServerOutput
from core import OutputReturn

@OnServerOutput
def on_server_output(severity, message):
    return OutputReturn.CONTINUE

This is crashing aswell (With the same conditions as in the video), this should answer both of your questions.

[jordanbriere]

Hmmm. What about this: core.zip?

[Frag1337]

I've replaced it, and it still crashes instantly, without any error. It just crashes.

I can also confirm that the same issue persists on Linux.

Edit:

When not loading any plugin, but doing the same condition where it usually crashes, I get the following output:

[jordanbriere]

What map/coordinates?

[Frag1337]

Map:
http://51.38.124.29/fastdl/cstrike/maps/surf_buck-wild_b02.bsp.bz2

Teleport inside trigger_push

setpos -1558.640869 1562.878906 -1974.968750;setang 2.930659 121.932831 0.000000

I'm pretty sure this crash is not related to the map, or this specific trigger_push, but it's the most easiest to reproduce with two players. It has to be something regarding the console output when being inside a trigger_push:

DataTable warning: player: Out-of-range value (2350.000000/1000.000000) in SendPropFloat 'm_vecBaseVelocity', clamping.

You could probably reproduce the same output alone, if you spawn a bot into the same coordinates without it being stuck.

Edit: @jordanbriere
I've made you a reproducable plugin. Just type test_teleport and it should teleport you & a bot into a trigger_push to reproduce the clamping spam.

test/test.py

from commands.server import ServerCommand
from core import OutputReturn
from cvars import ConVar
from filters.players import PlayerIter
from listeners import OnServerOutput
from mathlib import Vector


# surf_buck-wild_b02
coords1 = Vector(-1632, 1632, -2000)
coords2 = Vector(-1463, 1800, -2000)


def load():
    bot_quota = ConVar("bot_quota")
    bot_quota.set_int(1)


@ServerCommand("test_teleport")
def command_test_teleport(command):
    for player in PlayerIter():
        if player.dead:
            player.spawn()

        print("=> Teleporting {}".format(player.name))

        if player.is_bot():
            player.teleport(coords1, None, None)

        else:
            player.teleport(coords2, None, None)


@OnServerOutput
def on_server_output(severity, message):
    return OutputReturn.CONTINUE

Comment @OnServerOutput and both OutputReturn/OnServerOutput imports to reproduce your assertion failed message.

[jordanbriere]

Thanks. However, I'm unable to reproduce a crash. What is your current sp info, as well as your logging config?

[Frag1337]

Thats very weird, it's working every time for me.

Steps to reproduce for me: Type sp plugin load test and test_teleport into console, and its crashing for me instantly.

sp info

IMPORTANT: Please copy the full output.
--------------------------------------------------------
Checksum      : 7fa16f4b1046d1ef16fda2d600604871
Date          : 2021-08-25 20:49:23.166773
OS            : Windows-10-10.0.19041
Game          : css
SP version    : 705
Github commit : 38e4fe48579f9445b878624a9439ce10e28aa7e6
Server plugins:
   00: Source.Python, (C) 2012-2021, Source.Python Team.
SP plugins:
--------------------------------------------------------

[LOG_SETTINGS]
# Set to the logging level to use for Source.Python.

# To show all messages, set to level 5.
# To show debugging messages, set to at least level 4.
# To show informational messages, set to at least level 3.
# To show warning messages, set to at least level 2.
# To show exception messages, set to at least level 1.
# To show only critical and base messages, set to 0.
level = 2

# Set to the areas to log (console, main log, sp log, script log):
#   Console    = 1
#   Main log   = 2
#   SP log     = 4
#   Script log = 8
# Add each of the areas up and set the value to that number.
# Example:
#   To have the messages print to the console and be added to SP's log:
#       Console + SP log = 1 + 4 = 5
areas = 5

[jordanbriere]

What is the output of find log?

[Frag1337]

find log
"sp_notify_on_update" = "1" min. 0.000000 max. 1.000000
 - Log a warning when a Source.Python update is available. Requires sp_check_for_update to be set to 1.
"sp_logging_areas" = "5" ( def. "1" )
 - The Source.Python base logging areas
"sp_logging_level" = "2" ( def. "0" )
 - The Source.Python base logging level
"sv_debug_player_use" = "0"
 game replicated
 - Visualizes +use logic. Green cross=trace success, Red cross=trace too far, Green box=radius success
"dbghist_dump"
 game
 - Dump the debug history to the console. Format: <category id>
    Categories:
     0: Entity I/O
     1: AI Decisions
     2: Scene Print
     3: Alyx Blind
     4: Log of damage done to player
"log_verbose_enable" = "0"
 game
 - Set to 1 to enable verbose server log on the server.
"log_verbose_interval" = "3.0"
 game
 - Determines the interval (in seconds) for the verbose server log.
"mp_logdetail" = "0" min. 0.000000 max. 3.000000
 game
 - Logs attacks.  Values are: 0=off, 1=enemy, 2=teammate, 3=both)
"sv_netspike_output" = "1"
 - Where the netspike data be written?  Sum of the following values: 1=netspike.txt, 2=ordinary server log
"cl_logofile" = "materials/decals/spraylogo.vtf"
 archive
 - Spraypoint logo decal.
"con_timestamp" = "0"
 - Prefix console.log entries with timestamps
"con_logfile" = "console.log" ( def. "" )
 - Console output gets written to this file
"sv_logblocks" = "0"
 - If true when log when a query is blocked (can cause very large log files)
"sv_logsdir" = "logs"
 archive
 - Folder in the game directory where server logs will be stored.
"sv_logfile" = "1"
 archive
 - Log server information in the log file.
"sv_logflush" = "0"
 archive
 - Flush the log file to disk on each write (slow).
"sv_logecho" = "1"
 archive
 - Echo log information to the console.
"sv_log_onefile" = "0"
 archive
 - Log server information to only one file.
"sv_logbans" = "0"
 archive
 - Log server bans in the server logs.
"sv_logsecret" = "0"
 - If set then include this secret when doing UDP logging (will use 0x53 as packet type, not usual 0x52)
"sv_logfilename_format" = ""
 archive
 - Log filename format. See strftime for formatting codes.
"sv_logfilecompress" = "0"
 archive
 - Gzip compress logfile and rename to logfilename.log.gz on close.
"log"
 - Enables logging to file, console, and udp < on | off >.
"logaddress_add"
 - Set address and port for remote host <ip:port>.
"logaddress_delall"
 - Remove all udp addresses being logged to
"logaddress_del"
 - Remove address and port for remote host <ip:port>.
"logaddress_list"
 - List all addresses currently being used by logaddress.
"sv_rcon_log" = "1"
 - Enable/disable rcon logging.
"sv_setsteamaccount"
 - token
Set game server account token to use for logging in to a persistent game server account
"sv_logdownloadlist" = "1"
"sv_lowedict_action" = "0" min. 0.000000 max. 5.000000
 - 0 - no action, 1 - warn to log file, 2 - attempt to restart the game, if applicable, 3 - restart the map, 4 - go to the next map in the map cycle, 5 - spew all edicts.
"spew_consolelog_to_debugstring" = "0"
 - Send console log to PLAT_DebugString()
"joy_axisbutton_threshold" = "0.3"
 archive
 - Analog axis range before a button press is registered.