Added networked variants of the entity listeners.#351
Merged
Conversation
Member
|
Instead of just passing the index we could also pass the BaseEntity instance or maybe the Entity instance? |
Contributor
Author
I passed the index mainly because this is what we use internally, and that this is what is used first by the majority of codes on our forums (through custom entity class, or containers, etc.). However, now that you mention it, I think passing an |
…ks rather than an index.
…e is no callback registered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds networked variants of the entity listeners. The rationale behind this is that, 9 (if not 10) times out of 10, those listeners are used like so:
Which is redundant. That branch adds the following variants that only get called for networked entities:
Allowing for shorter codes, less calls, as well as removing the needs for every callbacks to validate themselves that they are working with networked entities, etc.