Fixed MemberFunction not returning the correct return type.

[CookStar]

If the Function has a converter, then the MemberFunction must also have a correct converter.

[jordanbriere]

If the Function has a converter, then the MemberFunction must also have a correct converter.

Thank you! This is a regression that was introduced when removing the copy constructor of the Function class to prevent reference/leak issues with its convention. Now that all (most?) convention issues have been addressed perhaps we could look into adding it back instead?

[CookStar]

Now that all (most?) convention issues have been addressed perhaps we could look into adding it back instead?

Indeed, I don't think there will be any problems, either.
Restored the copy constructor.

One question: In this part added by 6d26bca, why does it check m_pCallingConvention by dynamic_cast and not just by comparing with CONV_CUSTOM?

Source.Python/src/core/modules/memory/memory_function.cpp

Lines 199 to 200 in 227e954

	else if (m_eCallingConvention != CONV_CUSTOM && !dynamic_cast<ICallingConventionWrapper *>(m_pCallingConvention))
	m_pCallingConvention->m_bHooked = false;

If m_eCallingConvention isn't CONV_CUSTOM, I suppose there's no need to check further, is there?

[CookStar]

Removed m_bAllocatedCallingConvention, which was forgotten.

[jordanbriere]

One question: In this part added by 6d26bca, why does it check m_pCallingConvention by dynamic_cast and not just by comparing with CONV_CUSTOM?

It was added as extra security as mentioned into #344 (comment). However, feel free to remove it. Chances are that whole thing will collapse anyway if they are independently mutated. 😄

[jordanbriere]

I haven't tested, only hovered the changes, but is that necessary? I guess this is an additional reference reserved for DynamicHooks and it will be taken care of as well when the copy gets destroyed?

[CookStar]

This process is necessary to prevent the destructor from freeing up the memory, but it seems to cause a memory leak when the function is hooked related to another bug.

Details will be provided in a new pull request.

[jordanbriere]

Had a chance to run some tests just now and it passed everything I threw at it. Well done!

[CookStar]

I have been unable to access github for a long time, so I apologize for the delay in replying.

It was added as extra security as mentioned into #344 (comment). However, feel free to remove it. Chances are that whole thing will collapse anyway if they are independently mutated. 😄

Indeed, you were right, it totally dropped from my memory.