Fixed an animation error when setting a model to Player.#435
Merged
jordanbriere merged 2 commits intoNov 17, 2021
Conversation
CookStar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this only applies to CS:GO, but certain models seem to have problems with animation when the model is attached to player by model_index. It might be related to CCSGOPlayerAnimState::Reset(void) or something like that.
If the model is set by entity.model_index, the problem remains, but I can't decide what to do. Is it better to leave it as it is, as entity.model_name can't set the model?
Offsets other than Garry's Mod were borrowed from SourceMod, thanks to AlliedModders/SourceMod.