Skip to content

Fixed crash of non-precached model for Entity.set_model. #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordanbriere merged 1 commit into from
Nov 18, 2021
Merged

Fixed crash of non-precached model for Entity.set_model. #439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions addons/source-python/packages/source-python/entities/_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from entities.constants import INVALID_ENTITY_INDEX
# Engines
from engines.precache import Model
from engines.server import engine_server
from engines.sound import Attenuation
from engines.sound import Channel
from engines.sound import Pitch
Expand Down Expand Up @@ -434,6 +435,9 @@ def set_model(self, model):
"""
if isinstance(model, Model):
model = model.path
elif isinstance(model, str):
if not engine_server.is_model_precached(model):
raise ValueError(f'Model is not precached: {model}')

return [model]

Expand Down