Allow to hide information about pages in the menu

[dronelektron]

Sometimes it is not necessary to show navigation, for example, in the admin menu (as in SM)

[jordanbriere]

That whole block looks quite logically redundant to me. Couldn't we just extend buffer as we go? For example (untested):

buffer = ''
if self.title:
    buffer += _translate_text(self.title, player_index)
if self.show_pages:
    buffer += f' [{page.index + 1}/{self.page_count}]'
buffer = buffer.strip() + '\n'

[dronelektron]

Yes, I agree. Changed and tested the code, everything works fine.

[jordanbriere]

I would like to suggest the following changes:

buffer = ''
if self.title:
    buffer += _translate_text(self.title, player_index)
if self.show_pages:
    if buffer:
        buffer += ' '
    buffer += f'[{page.index + 1}/{self.page_count}]'
if buffer:
    buffer += '\n'

For 2 reasons:

• We don't want to add a leading space if there is no title.
• We don't want to add a new line if there is no title and no pagination.

[dronelektron]

Done

[jordanbriere]

Works great, thank you! Ideally, we should also add the same features to ESC menus for consistency.

[dronelektron]

Added support for "ListESCMenu" and "PagedESCMenu"

P.S. This type of menu works in "dod" as well

[dronelektron]

Also, I noticed a bug that the "ESC" menu does not close if you click the "Close" button (bottom right) or the cross (top right). Is it normal?

[dronelektron]

I am planning to add translation for the "Back", "Next" and "Close" buttons. Or make them language-neutral (at least), such as "<", ">" and "X", but this will be in a separate pull request.

[jordanbriere]

Also, I noticed a bug that the "ESC" menu does not close if you click the "Close" button (bottom right) or the cross (top right). Is it normal?

I'm not entirely sure, but I think the client does not tell the server when the menu is closed via these buttons, so it is getting resent until a selection is actually made.

[dronelektron]

Maybe consider these two buttons as selection "0" (Close)?

[Ayuto]

Thank you!