Skip to content

Removed unnecessary _BaseSound._unload_instance function.#496

Merged
Ayuto merged 3 commits into
Source-Python-Dev-Team:masterfrom
CookStar:patch-1
Apr 19, 2025
Merged

Removed unnecessary _BaseSound._unload_instance function.#496
Ayuto merged 3 commits into
Source-Python-Dev-Team:masterfrom
CookStar:patch-1

Conversation

@CookStar

Copy link
Copy Markdown
Contributor

This fixes the following error when unloading the plugin

Output:

[Source.Python]
[SP] Caught an Exception:
Traceback (most recent call last):
  File "..\addons\source-python\packages\source-python\plugins\manager.py", line 437, in _unload_auto_unload_instances
    instance._unload_instance()
  File "..\addons\source-python\packages\source-python\engines\sound.py", line 292, in _unload_instance
    self._downloads._unload_instance()
  File "..\addons\source-python\packages\source-python\stringtables\downloads.py", line 98, in _unload_instance
    _downloadables_list.remove(self)

ValueError: list.remove(x): x not in list

@Ayuto

Ayuto commented Apr 19, 2025

Copy link
Copy Markdown
Member

Thank you!

@Ayuto Ayuto merged commit 3a2ef92 into Source-Python-Dev-Team:master Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants