Remove the concealed checkbox from the Person form - #2223
Merged
Conversation
Person#concealed is publication state maintained automatically by the EventGroupQuery.set_concealed cascade (a person is concealed when all of their event groups are concealed). Hand-editing it invites confusion with the actual privacy controls (obscure_name, hide_age) and gets overwritten by the next cascade run, so remove it from the form and from the permitted parameters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the admin-only "Concealed (unsearchable)?" checkbox from the Person form and drops
concealedfromPersonParameters.permitted.Person#concealedis publication state, not a privacy control: it is maintained automatically by theEventGroupQuery.set_concealedcascade, which sets it true exactly when all of a person's event groups are concealed and reveals the person as soon as any of their event groups goes live. Hand-editing the flag invites confusion with the actual per-person privacy controls (obscure_name,hide_age) and gets silently overwritten by the next cascade run touching the person's event groups.The read-only "Concealed?" column on the admin people index is unchanged, so the state is still visible — it just can't be hand-edited anymore.
Testing
bundle exec rspec spec/system/visit_person_show_spec.rb— 8 examples, 0 failures🤖 Generated with Claude Code