Warn when a private event group's times feed projections - #2233
Merged
Conversation
New events default to use_for_projections = true, which is right for real events being set up pre-publication but silently includes test events with unrealistic times. Surface the combination at the three moments it matters: - The event form shows an inline warning under the checkbox when the event group is concealed - The setup and setup summary pages show a warning callout listing the projectable events with links to their edit forms - The Take Private confirmation adds a sentence noting the group's events will keep feeding projections unless unchecked Follow-up to #2229/#2231; see also #2169. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2229/#2231. New events default to
use_for_projections = true— correct for real events being set up pre-publication (concealed groups that will go public by race day), but it silently includes new non-public test events with messy or unrealistic data in the projection stream. This PR surfaces the concealed-but-projecting combination at the three moments a user can act on it:The default itself is deliberately unchanged: defaulting from concealment would silently drop every normal pre-publication event out of projections after it goes public — a worse failure in the common case — and would re-couple the two concepts #2229 just separated.
Testing
🤖 Generated with Claude Code