fix: correct AWS/IAM letter reading and voice StackOne word-by-word#42
Merged
Conversation
30e9062 to
5d8b043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pronunciation fixes in the dev-terms map. espeak reads a lone "A" as the article "uh", so
AWScame out "uh double-you ess"; and the org nameStackOnewas garbled as "stac kone".Changes
AWS/IAMread as letters — switch the spelled-out forms to the dotted form (A.W.S.,I.A.M.), which forces espeak to voice the letter name "ay" instead of the article "uh". (Spelling itAY/aydoesn't work — espeak reads that as "eye"; the dots are the trick.)stackone→ "stack one" — added to_DEV_PRONUNCIATIONSso it's spoken word-by-word.Testing
pytest— dev-term assertions updated toA.W.S./I.A.M., plus a new org-name test; 192 passing.ruff check .clean.A.W.S.→ˈeɪ.dˈʌbəljuː.ˈɛs.("ay double-you ess"),I.A.M.→ˈaɪ.ˈeɪ.ˈɛm.("eye ay em"),stack one→stˈæk wˌʌn.Related issues
Heads-up for review: baking an org name (
StackOne) into core is a deliberate exception to the speech-normalization non-goal ("no domain pronunciations in StackVox") — done on request so read-aloud tooling gets it without per-consumer wiring. The acronym fixes are generic espeak corrections and squarely in scope.