STAC-3401 blacklisted processes - #71
Merged
Merged
Conversation
TizianoPerrucci
suggested changes
Mar 13, 2019
| - "^sshd:" | ||
| - "^/bin/bash" | ||
| - "^/usr/bin/bash" | ||
| - "^/usr/lib/systemd/*" |
There was a problem hiding this comment.
is a * needed ?
I see other example like ^/usr/sbin which correctly ignores sshd (as I can see from the molecule expectations)
Author
There was a problem hiding this comment.
Mmm yes I think the * is not needed. I'll double check. The comparison / matching happens on the first argument of the cmd line. So in the case of sshd it actually matches only for ^sshd:
| - "^pickup" | ||
| - "^qmgr" | ||
| # Windows Specific patterns | ||
| - "cmd.exe" |
There was a problem hiding this comment.
can we order them alphabetically please :) ?
| # blacklist_patterns: | ||
| blacklist_patterns: | ||
| # Linux Specific patterns | ||
| - "^/sbin/" |
There was a problem hiding this comment.
can we order them alphabetically please :) ?
…s, added windows 2012 R2 server to Vagrant boxes
TizianoPerrucci
approved these changes
Mar 14, 2019
TizianoPerrucci
added a commit
that referenced
this pull request
Mar 22, 2019
This reverts commit bbaf280.
TizianoPerrucci
added a commit
that referenced
this pull request
Mar 22, 2019
TizianoPerrucci
pushed a commit
that referenced
this pull request
Mar 22, 2019
* stac-3401 blacklisted process names * added process filtering test to molecule * fixed lib/system/* process filtering * alphabetically order the blacklisted patterns, fix * wildcard patterns, added windows 2012 R2 server to Vagrant boxes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Adds default process blacklist of process that are typically uninteresting.
Motivation
What inspired you to submit this pull request?
STAC-3401 Story to filter uninteresting processes
Additional Notes
Anything else we should know when reviewing?