refactor(toolbar): make Active Connections a toolbar popover instead of a modal (#1350)

CHANGELOG.md

@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Import connections and passwords from DataGrip, including SSH tunnels and SSL settings. The source app doesn't need to be running. (#1374)
 
+### Changed
+
+- Active Connections is now a searchable popover anchored to the toolbar that closes on Escape or clicking outside, instead of a modal dialog. (#1350)
+
 ### Fixed
 
 - Raw SQL filter now suggests columns and keywords at every position in the expression, including after AND and OR, instead of only the first column. (#1346)

TablePro/Core/Services/Infrastructure/MainWindowToolbar+Buttons.swift

@@ -9,7 +9,7 @@ import SwiftUI
 import TableProPluginKit
 
 struct ConnectionToolbarButton: View {
-    let coordinator: MainContentCoordinator
+    @Bindable var coordinator: MainContentCoordinator
 
     var body: some View {
         Button {
@@ -18,6 +18,9 @@ struct ConnectionToolbarButton: View {
             Label("Connection", systemImage: "network")
         }
         .help(String(localized: "Switch Connection (⌘⌥C)"))
+        .popover(isPresented: $coordinator.isConnectionSwitcherShown, arrowEdge: .bottom) {
+            ConnectionSwitcherPopover()
+        }
     }
 }
 

TablePro/Views/Main/MainContentCommandActions.swift

@@ -815,7 +815,7 @@ final class MainContentCommandActions {
     }
 
     func openConnectionSwitcher() {
-        coordinator?.activeSheet = .connectionSwitcher
+        coordinator?.isConnectionSwitcherShown = true
     }
 
     // MARK: - Undo/Redo (Group A — Called Directly)

TablePro/Views/Main/MainContentCoordinator.swift

@@ -43,7 +43,6 @@ struct DisplayFormatsCacheEntry {
 /// Uses a single `.sheet(item:)` modifier instead of multiple `.sheet(isPresented:)`.
 enum ActiveSheet: Identifiable {
     case quickSwitcher
-    case connectionSwitcher
     case sqlPreview
     case exportDialog
     case importDialog
@@ -56,7 +55,6 @@ enum ActiveSheet: Identifiable {
     var id: String {
         switch self {
         case .quickSwitcher: "quickSwitcher"
-        case .connectionSwitcher: "connectionSwitcher"
         case .sqlPreview: "sqlPreview"
         case .exportDialog: "exportDialog"
         case .importDialog: "importDialog"
@@ -157,6 +155,7 @@ final class MainContentCoordinator {
     var tableMetadata: TableMetadata?
     var activeSheet: ActiveSheet?
     var isDatabaseSwitcherShown = false
+    var isConnectionSwitcherShown = false
     var databaseToDrop: String?
     var importFileURL: URL?
     var exportPreselectedTableNames: Set<String>?

TablePro/Views/Main/MainContentView.swift

@@ -257,8 +257,6 @@ struct MainContentView: View {
                 databaseType: connection.type,
                 onSelect: coordinator.handleQuickSwitcherSelection
             )
-        case .connectionSwitcher:
-            ConnectionSwitcherSheet(isPresented: dismissBinding)
         case .sqlPreview:
             SQLReviewSheet(
                 isPresented: dismissBinding,