refactor(datagrid): de-duplicate pagination helpers and guard All rows on unknown totals (#1364)#1411
Merged
Merged
Conversation
…s on unknown totals (#1364)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup to #1408 (the pagination bar, which is now merged). Internal refactors plus one small behavior guard, no change to the public surface.
Refactors (de-duplication)
PaginationState: extracted a privatesetPage(_:)that single-sources thecurrentOffset = (page - 1) * pageSizearithmetic previously repeated across six navigation methods.PaginationCoordinator: extracted a privateconfirmLargeFetch(...)for the warning-alert + sheet/modal presentation thatshowAllRowsandfetchAllRowsboth duplicated.PaginationControlsView: collapsed the two near-identical popovers (jump-to-page, custom page size) into onesubmitPopover(...)helper.MainStatusBarView: extractedisPagedWithUnknownTotal, shared byshowsPaginationControlsandrowInfoText.Behavior
Everything else is unchanged: same UI, same navigation/disabled logic, same
String(localized:)keys, and every navigation method keeps its exact guard and result (thePaginationStatetests still assert the samecurrentPage/currentOffset). SwiftLint--strictis clean.Not built locally; relying on CI / the Xcode build for the compile.