fix(plugin-mongodb): emit only JSON-valid numeric literals#1813
Open
andiahmads wants to merge 2 commits into
Open
fix(plugin-mongodb): emit only JSON-valid numeric literals#1813andiahmads wants to merge 2 commits into
andiahmads wants to merge 2 commits into
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MongoDB-generated filters and edit statements now only emit numeric literals when the value uses valid JSON number syntax. Values like
.5,1.,+7, and01stay quoted, so generated find, insert, update, and delete JSON remains parseable and preserves string-looking values. Valid JSON numbers, including decimals and exponent notation, still emit unquoted.Validation
xcodebuild -project TablePro.xcodeproj -scheme TablePro -skipPackagePluginValidation -only-testing:TableProTests/MongoDBQueryBuilderTests -only-testing:TableProTests/MongoDBStatementGeneratorTests CODE_SIGNING_ALLOWED=NO testxcodebuild -project TablePro.xcodeproj -scheme TablePro -skipPackagePluginValidation -only-testing:TableProTests/MongoShellParserTests -only-testing:TableProTests/MongoDBExtendedJsonTests -only-testing:TableProTests/BsonDocumentFlattenerTests CODE_SIGNING_ALLOWED=NO testswiftlint lint --strictgit diff --check