fix(plugin-oracle): let the driver open and report a transaction - #3004
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two files from #3001 were left out of that commit by mistake, so
maindoes not compile the Oracle plugin:OracleCoreErrorgainedtransactionLostand the plugin's diagnostics switch has no arm for it (AllPluginsfails with "switch must be exhaustive").It also restores the macOS half of #3001's behaviour, which that PR described and shipped without:
beginTransaction()opens the transaction in the core instead of doing nothing, so a batch, a grid save or an MCP client that opens one is held open untilCOMMITorROLLBACK.sessionTransactionState()answers from the core, so the app joins a transaction the user opened rather than committing each statement inside it.AllPluginscompiles again. The iOS driver already had both, and the package tests and the app tests for this shipped with #3001.