test(plugin-kafka): spread the group sweep over three coordinators instead of six - #3024
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3023, which merged while this was still being verified.
showGroupsCoversEveryBrokercommitted offsets for six consumer groups, and each one runs a console consumer in its own container. On the run that caught this the test host was killed mid-case withTest crashed with signal termat 0.000 seconds, while the other 33 integration cases passed; the whole testing phase had taken 34.8 seconds. It is a cost problem, not an assertion problem.Three groups is the fewest that can land on three coordinators, which is all the assertion needs: the test exists to prove
SHOW GROUPSasks every broker rather than only the one the connection was opened to, and which broker coordinates a group is a hash of its id.Verification
verify.sh testover the nine Kafka suites, against the three-broker clusterscripts/kafka-test-broker.sh up --brokers 3starts:That is the run this commit was needed for. The same command on the previous commit reported 151 of 152 with the terminated case.