fix(offline): fence individual outbox clear deletions

[tannerlinsley]

Clearing multiple outbox entries now records each successful deletion immediately. Previously an overlapping read could return an already-deleted transaction while another deletion was pending, or after another deletion failed.

Reuse removeMany() so clear has the same per-entry removal fencing as normal acknowledgments. This closes the remaining clear/read boundary from #1822.

Validation: both new regression cases fail before the fix and pass afterward; all 148 offline transaction tests pass, along with standalone TypeScript, changed-file lint, and formatting. Includes a patch changeset.

Summary by CodeRabbit

• Bug Fixes
  • Improved offline transaction clearing to prevent overlapping reads from returning transactions that were successfully removed.
  • Ensured clearing remains consistent when another transaction deletion is still pending or encounters an error.
  • Improved error handling so failed clearing operations are reported correctly.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 6f0ffaa0-7aab-4f38-a20d-50e927ae0f74

📥 Commits

Reviewing files that changed from the base of the PR and between 179d003 and b7b3240.

📒 Files selected for processing (3)

• .changeset/fix-outbox-clear-removal-fence.md
• packages/offline-transactions/src/outbox/OutboxManager.ts
• packages/offline-transactions/tests/leadership-replay.property.test.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.

---

📝 Walkthrough

Walkthrough

OutboxManager.clear now removes transactions individually through removeMany. A property test verifies that successful deletions fence overlapping reads while peer deletion is pending or fails. A patch changeset documents the fix.

Changes

Outbox clear fencing

Layer / File(s)	Summary
Individual clear deletions packages/offline-transactions/src/outbox/OutboxManager.ts, packages/offline-transactions/tests/leadership-replay.property.test.ts, .changeset/fix-outbox-clear-removal-fence.md	OutboxManager.clear delegates removals to removeMany. The parameterized property test covers pending and failed peer deletions and verifies that in-flight reads exclude successfully removed rows. The changeset records the patch.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: kyleamathews

Merge Risk: ⚪ Minimal · up to b7b32

Clear operations now fence each successfully deleted transaction without hiding transactions whose deletion is still pending or failed. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: fencing individual outbox clear deletions.
Description check	✅ Passed	The description explains the change, motivation, validation, test results, and patch changeset. It does not use the template headings or checklist format, but it contains the required information and …
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/outbox-clear-removal-fence

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[pkg-pr-new]

More templates

• todos
• offline-first-electron
• @tanstack/db-example-react-next-ssr-e2e
• tanstack-start-example-basic
• @tanstack/db-example-paced-mutations-demo
• tanstack-start-db-projects-example
• @tanstack/db-example-react-start-ssr-e2e
• @tanstack/db-example-react-todo
• offline-transactions-react-native
• shopping-list-react-native
• @tanstack/db-example-solid-todo

@tanstack/angular-db

npm i https://pkg.pr.new/@tanstack/angular-db@1836

@tanstack/browser-db-sqlite-persistence

npm i https://pkg.pr.new/@tanstack/browser-db-sqlite-persistence@1836

@tanstack/capacitor-db-sqlite-persistence

npm i https://pkg.pr.new/@tanstack/capacitor-db-sqlite-persistence@1836

@tanstack/cloudflare-durable-objects-db-sqlite-persistence

npm i https://pkg.pr.new/@tanstack/cloudflare-durable-objects-db-sqlite-persistence@1836

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@1836

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@1836

@tanstack/db-sqlite-persistence-core

npm i https://pkg.pr.new/@tanstack/db-sqlite-persistence-core@1836

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@1836

@tanstack/electron-db-sqlite-persistence

npm i https://pkg.pr.new/@tanstack/electron-db-sqlite-persistence@1836

@tanstack/expo-db-sqlite-persistence

npm i https://pkg.pr.new/@tanstack/expo-db-sqlite-persistence@1836

@tanstack/node-db-sqlite-persistence

npm i https://pkg.pr.new/@tanstack/node-db-sqlite-persistence@1836

@tanstack/offline-transactions

npm i https://pkg.pr.new/@tanstack/offline-transactions@1836

@tanstack/powersync-db-collection

npm i https://pkg.pr.new/@tanstack/powersync-db-collection@1836

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@1836

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@1836

@tanstack/react-native-db-sqlite-persistence

npm i https://pkg.pr.new/@tanstack/react-native-db-sqlite-persistence@1836

@tanstack/react-router-with-db

npm i https://pkg.pr.new/@tanstack/react-router-with-db@1836

@tanstack/rxdb-db-collection

npm i https://pkg.pr.new/@tanstack/rxdb-db-collection@1836

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@1836

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@1836

@tanstack/tauri-db-sqlite-persistence

npm i https://pkg.pr.new/@tanstack/tauri-db-sqlite-persistence@1836

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@1836

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@1836

commit: b7b3240

[github-actions]

Size Change: 0 B

Total Size: 165 kB

ℹ️ View Unchanged

Filename	Size
packages/db/dist/esm/client.js	3.66 kB
packages/db/dist/esm/collection-options.js	236 B
packages/db/dist/esm/collection/change-events.js	1.44 kB
packages/db/dist/esm/collection/changes.js	2.23 kB
packages/db/dist/esm/collection/cleanup-queue.js	794 B
packages/db/dist/esm/collection/events.js	481 B
packages/db/dist/esm/collection/index.js	4.58 kB
packages/db/dist/esm/collection/indexes.js	1.99 kB
packages/db/dist/esm/collection/lifecycle.js	2.15 kB
packages/db/dist/esm/collection/mutations.js	2.53 kB
packages/db/dist/esm/collection/state.js	6.44 kB
packages/db/dist/esm/collection/subscription.js	8.72 kB
packages/db/dist/esm/collection/sync.js	4.62 kB
packages/db/dist/esm/collection/transaction-metadata.js	144 B
packages/db/dist/esm/deferred.js	207 B
packages/db/dist/esm/errors.js	5.26 kB
packages/db/dist/esm/event-emitter.js	964 B
packages/db/dist/esm/index.js	3.68 kB
packages/db/dist/esm/indexes/auto-index.js	829 B
packages/db/dist/esm/indexes/base-index.js	1.14 kB
packages/db/dist/esm/indexes/basic-index.js	2.07 kB
packages/db/dist/esm/indexes/btree-index.js	2.26 kB
packages/db/dist/esm/indexes/index-registry.js	820 B
packages/db/dist/esm/indexes/reverse-index.js	376 B
packages/db/dist/esm/live-query-adapter.js	318 B
packages/db/dist/esm/live-query-observer.js	3.69 kB
packages/db/dist/esm/live-query-options.js	702 B
packages/db/dist/esm/live-query-window-controller.js	4.36 kB
packages/db/dist/esm/local-only.js	975 B
packages/db/dist/esm/local-storage.js	2.15 kB
packages/db/dist/esm/optimistic-action.js	359 B
packages/db/dist/esm/paced-mutations.js	496 B
packages/db/dist/esm/proxy.js	3.32 kB
packages/db/dist/esm/query/builder/functions.js	1.47 kB
packages/db/dist/esm/query/builder/index.js	6.69 kB
packages/db/dist/esm/query/builder/query-ir.js	116 B
packages/db/dist/esm/query/builder/ref-proxy.js	1.24 kB
packages/db/dist/esm/query/compiler/evaluators.js	1.92 kB
packages/db/dist/esm/query/compiler/expressions.js	560 B
packages/db/dist/esm/query/compiler/group-by.js	4.13 kB
packages/db/dist/esm/query/compiler/index.js	9.06 kB
packages/db/dist/esm/query/compiler/joins.js	3 kB
packages/db/dist/esm/query/compiler/lazy-targets.js	1.1 kB
packages/db/dist/esm/query/compiler/order-by.js	1.91 kB
packages/db/dist/esm/query/compiler/parent-routes.js	319 B
packages/db/dist/esm/query/compiler/route-metadata.js	1.24 kB
packages/db/dist/esm/query/compiler/select.js	1.58 kB
packages/db/dist/esm/query/effect.js	4.6 kB
packages/db/dist/esm/query/equality-value-identity.js	591 B
packages/db/dist/esm/query/expression-helpers.js	1.43 kB
packages/db/dist/esm/query/ir-stable-identity.js	4.04 kB
packages/db/dist/esm/query/ir.js	1.59 kB
packages/db/dist/esm/query/live-query-collection.js	391 B
packages/db/dist/esm/query/live/bucket-facade-adapter.js	2.73 kB
packages/db/dist/esm/query/live/collection-config-builder.js	6.97 kB
packages/db/dist/esm/query/live/collection-registry.js	264 B
packages/db/dist/esm/query/live/collection-subscriber.js	2.25 kB
packages/db/dist/esm/query/live/internal.js	145 B
packages/db/dist/esm/query/live/materialized-pipeline.js	2.32 kB
packages/db/dist/esm/query/live/ordered-source-loader.js	3.14 kB
packages/db/dist/esm/query/live/subset-demand-controller.js	1.26 kB
packages/db/dist/esm/query/live/utils.js	1.14 kB
packages/db/dist/esm/query/optimizer.js	2.91 kB
packages/db/dist/esm/query/query-once.js	359 B
packages/db/dist/esm/query/runtime-reference-identity.js	572 B
packages/db/dist/esm/query/subset-dedupe.js	486 B
packages/db/dist/esm/scheduler.js	1.34 kB
packages/db/dist/esm/SortedMap.js	1.3 kB
packages/db/dist/esm/strategies/debounceStrategy.js	247 B
packages/db/dist/esm/strategies/queueStrategy.js	428 B
packages/db/dist/esm/strategies/throttleStrategy.js	246 B
packages/db/dist/esm/transactions.js	3.51 kB
packages/db/dist/esm/utils.js	1.01 kB
packages/db/dist/esm/utils/array-utils.js	270 B
packages/db/dist/esm/utils/browser-polyfills.js	304 B
packages/db/dist/esm/utils/btree.js	4.51 kB
packages/db/dist/esm/utils/callbacks.js	174 B
packages/db/dist/esm/utils/comparison.js	1.49 kB
packages/db/dist/esm/utils/cursor.js	676 B
packages/db/dist/esm/utils/error.js	167 B
packages/db/dist/esm/utils/get-or-create.js	155 B
packages/db/dist/esm/utils/index-optimization.js	2.42 kB
packages/db/dist/esm/utils/type-guards.js	230 B
packages/db/dist/esm/utils/uuid.js	449 B
packages/db/dist/esm/virtual-props.js	360 B

_{compressed-size-action::db-package-size}

[github-actions]

Size Change: 0 B

Total Size: 7.34 kB

ℹ️ View Unchanged

Filename	Size
packages/react-db/dist/esm/DbProvider.js	317 B
packages/react-db/dist/esm/HydrationBoundary.js	263 B
packages/react-db/dist/esm/index.js	330 B
packages/react-db/dist/esm/live-query-internals.js	282 B
packages/react-db/dist/esm/useLiveInfiniteQuery.js	1.9 kB
packages/react-db/dist/esm/useLiveQuery.js	2.68 kB
packages/react-db/dist/esm/useLiveQueryEffect.js	355 B
packages/react-db/dist/esm/useLiveSuspenseQuery.js	812 B
packages/react-db/dist/esm/usePacedMutations.js	401 B

_{compressed-size-action::react-db-package-size}